-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test various calling patterns of net.connect() related functions #11847
Conversation
92d8243
to
44a1b04
Compare
44a1b04
to
8d6ee2c
Compare
Error messages vary on different machines..loosen up the message validation and try again. CI: https://ci.nodejs.org/job/node-test-pull-request/6850/ |
046cc82
to
969e285
Compare
d2d8b48
to
40e984d
Compare
Something is wrong with @jasnell PTAL, thanks. CI is green now: https://ci.nodejs.org/job/node-test-pull-request/6867/ |
Still LGTM! |
PR-URL: #11847 Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 7b830f4 |
PR-URL: nodejs#11847 Reviewed-By: James M Snell <jasnell@gmail.com>
This PR need backport to v7 |
@joyeecheung Should this be backported to If it is backported, the PR should include #12601. |
Related: #11761
This PR adds coverage to more calling patterns of
net.connect
:net.connect()
,net.createConnection()
,new Socket().connect()
with/without callback, withport
passed in plain argument/in optiontest-net-create-connection.js
and rename it totest-net-connect-options-port.js
connect(path)
test-net-connect-options.js
, add tests for morenew Socket()
options.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test, net