Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v7.x backport) test: add more and refactor test cases to net.connect #12325

Closed
wants to merge 1 commit into from
Closed

(v7.x backport) test: add more and refactor test cases to net.connect #12325

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

PR-URL: #11847

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v7.x labels Apr 11, 2017
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7324/

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Apr 11, 2017
@joyeecheung
Copy link
Member Author

This needs review..Ping @nodejs/release @jasnell

@joyeecheung
Copy link
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/7988/

@Trott
Copy link
Member

Trott commented Jul 15, 2017

Unfortunately, there are no more 7.x releases planned. Sorry this was never landed! I'm going to close it now.

@Trott Trott closed this Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyeecheung @Trott @mscdex @nodejs-github-bot