Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.x: backport V8 fixes for parser bugs #12037

Closed
wants to merge 3 commits into from
Closed

v6.x: backport V8 fixes for parser bugs #12037

wants to merge 3 commits into from

Commits on Mar 25, 2017

  1. deps: backport 2cabc86 from upstream V8 

    Original commit message:

    Fix classifier related bug

    R=adamk@chromium.org
    BUG=chromium:621111
    LOG=N

    Review-Url: https://codereview.chromium.org/2086513002
    Cr-Commit-Position: refs/heads/master@{nodejs#37150}

Fixes: nodejs#11977
    @targos
    targos committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    5301126 View commit details
    Browse the repository at this point in the history

  2. deps: cherry-pick b9f682b from upstream V8 

    Original commit message:

    Fix bug with illegal spread as single arrow parameter

    R=adamk@chromium.org
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{nodejs#37196}

Fixes: nodejs#12017
    @targos
    targos committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    7a38c51 View commit details
    Browse the repository at this point in the history

  3. deps: backport e427300 from upstream V8 

    Original commit message:

    Properly handle holes following spreads in array literals

    Before this change, the spread desugaring would naively call
    `%AppendElement($R, the_hole)` and in some cases $R would have
    a non-holey elements kind, putting the array into the bad state
    of exposing holes to author code.

    This patch avoids calling %AppendElement with a hole, instead
    simply incrementing $R.length when it sees a hole in the literal
    (this is safe because $R is known to be an Array). The existing
    logic for elements transitions takes care of giving the array a
    holey ElementsKind.

    BUG=chromium:644215

    Review-Url: https://codereview.chromium.org/2321533003
    Cr-Commit-Position: refs/heads/master@{nodejs#39294}

Fixes: nodejs#12018
    @targos
    targos committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    ade2402 View commit details
    Browse the repository at this point in the history