Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: update WHATWG URL parser to latest spec #12523

Closed
wants to merge 1 commit into from

Commits on Apr 23, 2017

  1. url: update WHATWG URL parser to latest spec

    - Update to spec
      - Add opaque hosts
      - File state did not correctly deal with lack of base URL
      - Cleanup API for file and non-special URLs
      - Allow % and IPv6 addresses in non-special URL hosts
      - Use specific names for percent-encode sets
      - Add empty host concept for file and non-special URLs
      - Clarify IPv6 serializer
    - Fix existing mistakes
      - Add missing ':' to forbidden host code point list.
      - Correct IPv4 parser empty label behavior
    - Maintain type equivalence in URLContext with spec
      - scheme, username, and password should always be strings
      - host, port, query, and fragment may be strings or null
      - Align scheme state more closely with the spec
      - Make sure the `special` variable is always synced with
        URL_FLAG_SPECIAL.
    
    PR-URL: nodejs#12523
    Fixes: nodejs#10608
    Fixes: nodejs#10634
    Refs: whatwg/url#185
    Refs: whatwg/url#225
    Refs: whatwg/url#224
    Refs: whatwg/url#218
    Refs: whatwg/url#243
    Refs: whatwg/url#260
    Refs: whatwg/url#268
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    TimothyGu committed Apr 23, 2017
    Configuration menu
    Copy the full SHA
    e0530f1 View commit details
    Browse the repository at this point in the history