build: reduce one level of spawning in node_gyp #12653

refack · 2017-04-25T21:37:42Z

configure will now call node_gyp as a module instead of forking
makes it easier to debug

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

bnoordhuis · 2017-04-26T08:29:05Z

tools/gyp_node.py

+  args.append(os.path.join(arg_path, 'node.gyp'))
+  common_fn  = os.path.join(arg_path, 'common.gypi')
+  options_fn = os.path.join(arg_path, 'config.gypi')
+  options_fips_fn = os.path.join(arg_path, 'config_fips.gypi')


Don't make unrelated changes in a single commit, split it out into two commits.

~~Split. or should it be Splat~~ Done.

bnoordhuis · 2017-04-26T08:31:47Z

configure

@@ -1400,4 +1401,5 @@ gyp_args += args
 if warn.warned:
  warn('warnings were emitted in the configure phase')

-sys.exit(subprocess.call(gyp_args))
+errorlevel = run_gyp(gyp_args)
+sys.exit(errorlevel)


Superfluous. errorlevel is always zero because run_gyp() exits on error.

refack · 2017-04-26T13:29:12Z

@bnoordhuis fixed PTAL

bnoordhuis

LGTM modulo comments.

bnoordhuis · 2017-05-15T11:50:48Z

tools/gyp_node.py

-    options_fips_fn = os.path.join(os.path.abspath(node_root), 'config_fips.gypi')
+  arg_path = node_root if sys.platform == 'win32' else os.path.abspath(node_root)
+  args.append(os.path.join(arg_path, 'node.gyp'))
+  common_fn  = os.path.join(arg_path, 'common.gypi')


While you're here, can you drop the extraneous space before the =?

bnoordhuis · 2017-05-15T11:51:24Z

tools/gyp_node.py

-    common_fn  = os.path.join(os.path.abspath(node_root), 'common.gypi')
-    options_fn = os.path.join(os.path.abspath(node_root), 'config.gypi')
-    options_fips_fn = os.path.join(os.path.abspath(node_root), 'config_fips.gypi')
+  arg_path = node_root if sys.platform == 'win32' else os.path.abspath(node_root)


bnoordhuis · 2017-05-15T11:51:52Z

tools/gyp_node.py

+
+
+if __name__ == '__main__':
+  args = sys.argv[1:]
  gyp_args = list(args)
  run_gyp(gyp_args)


You can just run_gyp(sys.argv[1:]) here, it's already a list.

bnoordhuis · 2017-05-15T11:52:55Z

By the way, the second commit log should be brought up to par with the style guide.

refack · 2017-05-15T17:20:08Z

By the way, the second commit log should be brought up to par with the style guide.

Ack

refack · 2017-05-15T17:34:31Z

Addressed all comments and rebased.
I'll leave this here another day...
/cc @nodejs/build
CI: https://ci.nodejs.org/job/node-test-commit/9896/
(CI fails are false negatives)

`configure` will now call `node_gyp` as a module instead of forking makes it easier to debug PR-URL: nodejs#12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: nodejs#12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

refack · 2017-05-16T19:32:13Z

landed in 8035527

refack · 2017-05-16T19:33:33Z

Post land double check master: https://ci.nodejs.org/job/node-test-commit/9928/

`configure` will now call `node_gyp` as a module instead of forking makes it easier to debug PR-URL: nodejs#12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: nodejs#12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins · 2017-06-22T18:52:33Z

should this be backported to v6.x?

refack · 2017-06-22T19:39:31Z

should this be backported to v6.x?

I think so.

PR-URL: #12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

`configure` will now call `node_gyp` as a module instead of forking makes it easier to debug PR-URL: #12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Apr 25, 2017

refack requested a review from sam-github April 25, 2017 21:37

refack self-assigned this Apr 25, 2017

bnoordhuis requested changes Apr 26, 2017

View reviewed changes

refack force-pushed the node-gyp-opt branch from 09cf3e1 to 1023476 Compare April 26, 2017 13:28

bnoordhuis approved these changes May 15, 2017

View reviewed changes

refack force-pushed the node-gyp-opt branch from 1023476 to 1e8aa47 Compare May 15, 2017 17:30

gibfahn approved these changes May 15, 2017

View reviewed changes

refack added 2 commits May 16, 2017 15:26

build: reduce one level of spawning in node_gyp

4aff056

`configure` will now call `node_gyp` as a module instead of forking makes it easier to debug PR-URL: nodejs#12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

build: simplify if in setting of arg_paths

8035527

PR-URL: nodejs#12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

refack force-pushed the node-gyp-opt branch from 1e8aa47 to 8035527 Compare May 16, 2017 19:26

refack merged commit 8035527 into nodejs:master May 16, 2017

refack deleted the node-gyp-opt branch May 16, 2017 19:33

refack restored the node-gyp-opt branch May 16, 2017 21:49

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017

build: simplify if in setting of arg_paths

9d81fc9

PR-URL: nodejs#12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

refack deleted the node-gyp-opt branch May 19, 2017 19:34

refack restored the node-gyp-opt branch May 25, 2017 23:10

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

refack deleted the node-gyp-opt branch June 10, 2017 21:26

refack removed their assignment Jun 12, 2017

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the lts-watch-v6.x label Jun 22, 2017

MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels Jun 23, 2017

MylesBorins pushed a commit that referenced this pull request Jun 23, 2017

build: simplify if in setting of arg_paths

923b920

PR-URL: #12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jul 11, 2017

build: simplify if in setting of arg_paths

7bda962

PR-URL: #12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins mentioned this pull request Jul 18, 2017

v6.11.2 proposal #14356

Merged

MylesBorins mentioned this pull request Aug 16, 2017

v6.11.3-proposal #14852

Merged

snyk-bot mentioned this pull request Mar 18, 2020

[Snyk] Upgrade eslint from 6.3.0 to 6.8.0 O330oei/node#4

Open

snyk-bot mentioned this pull request Apr 1, 2020

[Snyk] Upgrade eslint from 6.3.0 to 6.8.0 O330oei/node#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: reduce one level of spawning in node_gyp #12653

build: reduce one level of spawning in node_gyp #12653

refack commented Apr 25, 2017

bnoordhuis Apr 26, 2017

refack Apr 26, 2017 •

edited

Loading

bnoordhuis Apr 26, 2017

refack commented Apr 26, 2017

bnoordhuis left a comment

bnoordhuis May 15, 2017

bnoordhuis May 15, 2017

bnoordhuis May 15, 2017

bnoordhuis commented May 15, 2017

refack commented May 15, 2017

refack commented May 15, 2017 •

edited

Loading

refack commented May 16, 2017

refack commented May 16, 2017

MylesBorins commented Jun 22, 2017

refack commented Jun 22, 2017

build: reduce one level of spawning in node_gyp #12653

build: reduce one level of spawning in node_gyp #12653

Conversation

refack commented Apr 25, 2017

Checklist

Affected core subsystem(s)

bnoordhuis Apr 26, 2017

Choose a reason for hiding this comment

refack Apr 26, 2017 • edited Loading

Choose a reason for hiding this comment

bnoordhuis Apr 26, 2017

Choose a reason for hiding this comment

refack commented Apr 26, 2017

bnoordhuis left a comment

Choose a reason for hiding this comment

bnoordhuis May 15, 2017

Choose a reason for hiding this comment

bnoordhuis May 15, 2017

Choose a reason for hiding this comment

bnoordhuis May 15, 2017

Choose a reason for hiding this comment

bnoordhuis commented May 15, 2017

refack commented May 15, 2017

refack commented May 15, 2017 • edited Loading

refack commented May 16, 2017

refack commented May 16, 2017

MylesBorins commented Jun 22, 2017

refack commented Jun 22, 2017

refack Apr 26, 2017 •

edited

Loading

refack commented May 15, 2017 •

edited

Loading