Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: reduce one level of spawning in node_gyp #12653

Merged
merged 2 commits into from
May 16, 2017
Merged

build: reduce one level of spawning in node_gyp #12653

merged 2 commits into from
May 16, 2017

Commits on May 16, 2017

  1. build: reduce one level of spawning in node_gyp 

    `configure` will now call `node_gyp` as a module instead of forking
makes it easier to debug

PR-URL: nodejs#12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @refack
    refack committed May 16, 2017
    Configuration menu
    Copy the full SHA
    4aff056 View commit details
    Browse the repository at this point in the history

  2. build: simplify if in setting of arg_paths 

    PR-URL: nodejs#12653
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @refack
    refack committed May 16, 2017
    Configuration menu
    Copy the full SHA
    8035527 View commit details
    Browse the repository at this point in the history