Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #1577

Merged
merged 2 commits into from
May 4, 2015

Conversation

bnoordhuis
Copy link
Member

@mscdex mscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 1, 2015
@trevnorris
Copy link
Contributor

LGTM

Pass the isolate explicitly.  Overlooked in commit ccb199a ("src: fix
deprecation warnings") because g++ 4.8 and 4.9 don't warn for it
whereas g++ 5.1 does.

PR-URL: nodejs#1577
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Commit ccb199a ("src: fix deprecation warnings") passes env()->isolate()
to the Buffer::New() call.  It's somewhat inefficient because the callee
looks up the environment from the isolate.  Just pass the env directly.

PR-URL: nodejs#1577
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis bnoordhuis merged commit 2ed10f1 into nodejs:master May 4, 2015
@bnoordhuis bnoordhuis deleted the fix-deprecation-warnings branch May 4, 2015 22:43
@rvagg rvagg mentioned this pull request May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants