Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings #1577

Merged
merged 2 commits into from
May 4, 2015
Merged

Fix deprecation warnings #1577

merged 2 commits into from
May 4, 2015

Commits on May 4, 2015

  1. src: fix deprecated use of Buffer::New() 

    Pass the isolate explicitly.  Overlooked in commit ccb199a ("src: fix
deprecation warnings") because g++ 4.8 and 4.9 don't warn for it
whereas g++ 5.1 does.

PR-URL: nodejs#1577
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed May 4, 2015
    Configuration menu
    Copy the full SHA
    f696c9e View commit details
    Browse the repository at this point in the history

  2. src: fix minor inefficiency in Buffer::New() call 

    Commit ccb199a ("src: fix deprecation warnings") passes env()->isolate()
to the Buffer::New() call.  It's somewhat inefficient because the callee
looks up the environment from the isolate.  Just pass the env directly.

PR-URL: nodejs#1577
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed May 4, 2015
    Configuration menu
    Copy the full SHA
    2ed10f1 View commit details
    Browse the repository at this point in the history