Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.fixtures.path() #16109

Closed
wants to merge 1 commit into from
Closed

test: use common.fixtures.path() #16109

wants to merge 1 commit into from

Conversation

tobbik
Copy link
Contributor

@tobbik tobbik commented Oct 9, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 9, 2017
@tobbik tobbik mentioned this pull request Oct 9, 2017
Closed
2 tasks
jasnell
jasnell reviewed Oct 9, 2017
View reviewed changes
test/parallel/test-fs-readfile-fd.js
@@ -1,9 +1,10 @@
'use strict';
const common = require('../common');
require('../common');
const fixturesPath = require('../common/fixtures').path();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close, but would be better as:

const fixtures = require('../common/fixtures');

then ...

const fn = fixtures.path('empty.txt');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

Here is another one:
#16112

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobbik, I'm going to close this one in favor of #16112 then. Just for future reference, you can update an existing PR by pushing changes to the corresponding branch on your GitHub.

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 10, 2017
@cjihrig cjihrig closed this Oct 10, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 10, 2017
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@cjihrig cjihrig cjihrig left review comments

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tobbik @jasnell @cjihrig @mscdex @Trott @nodejs-github-bot