Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.fixtures.path() #16112

Closed
wants to merge 1 commit into from
Closed

test: use common.fixtures.path() #16112

wants to merge 1 commit into from

Conversation

tobbik
Copy link
Contributor

@tobbik tobbik commented Oct 9, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 9, 2017
@tobbik tobbik mentioned this pull request Oct 9, 2017
Closed
2 tasks
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 10, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 10, 2017
@Trott
Copy link
Member

Trott commented Oct 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10592/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 11, 2017
@tobbik @Trott
test: use common.fixtures.path()
7525df7 
PR-URL: nodejs#16112
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@Trott
Copy link
Member

Trott commented Oct 11, 2017

Landed in 7525df7.
Thanks for the contribution! 🎉

@Trott Trott closed this Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@tobbik @addaleax
test: use common.fixtures.path()
d91cf2d 
PR-URL: nodejs/node#16112
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@tobbik @targos
test: use common.fixtures.path()
92b5cf1 
PR-URL: #16112
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@tobbik @MylesBorins
test: use common.fixtures.path()
3735a67 
PR-URL: #16112
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tobbik @MylesBorins
test: use common.fixtures.path()
abba5e7 
PR-URL: #16112
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tobbik @MylesBorins
test: use common.fixtures.path()
788d7db 
PR-URL: #16112
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tobbik @Trott @Qard @cjihrig @tniessen @mscdex @MylesBorins @nodejs-github-bot