doc: document resolve hook formats #16375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/api/esm.md
Outdated
| | `"cjs"` | Load a node-style CommonJS module | | ||
| | `"builtin"` | Load a node builtin CommonJS module | | ||
| | `"json"` | Load a JSON file | | ||
| | `"addon"` | Load a [C++ Addon](./addons.md) | |
There was a problem hiding this comment.
It seems this should be (addons.html) for referring to the compiled doc,
doc/api/esm.md
Outdated
| | `"builtin"` | Load a node builtin CommonJS module | | ||
| | `"json"` | Load a JSON file | | ||
| | `"addon"` | Load a [C++ Addon](./addons.md) | | ||
| | `"dynamic"` | Use a [dynamic instantiate hook](#dynamic-instantiate-hook) | |
There was a problem hiding this comment.
The same: in the compiled doc the hash is (#esm_dynamic_instantiate_hook)
|
Hi @azz! Thank you for improving the docs! You can add a fixing commit to this branch or amend the existing one. Let us know if you need any help with this. |
|
Fixed. Thanks for catching that! |
Add `"dynamic"` to the list of supported `format`s returned by a custom resolve hook. Add a table describing the meaning of each `format`. Refs: nodejs#15445
|
Changed it to follow the convention of using link references. |
hiroppy
added
the
esm
hiroppy
approved these changes
Nov 10, 2017
BridgeAR
approved these changes
Nov 23, 2017
BridgeAR
added
the
author ready
|
Landed in e5d4aeb |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2017
Add `"dynamic"` to the list of supported `format`s returned by a custom resolve hook. Add a table describing the meaning of each `format`. PR-URL: #16375 Refs: #15445 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add `"dynamic"` to the list of supported `format`s returned by a custom resolve hook. Add a table describing the meaning of each `format`. PR-URL: #16375 Refs: #15445 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add `"dynamic"` to the list of supported `format`s returned by a custom resolve hook. Add a table describing the meaning of each `format`. PR-URL: #16375 Refs: #15445 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Add `"dynamic"` to the list of supported `format`s returned by a custom resolve hook. Add a table describing the meaning of each `format`. PR-URL: #16375 Refs: #15445 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Add `"dynamic"` to the list of supported `format`s returned by a custom resolve hook. Add a table describing the meaning of each `format`. PR-URL: #16375 Refs: #15445 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed
format: "dynamic"was missing from the docs (it's mentioned later on).Add
"dynamic"to the list of supportedformats returned by a custom resolve hook.Add a table describing the meaning of each
format.Refs: #15445
Checklist
Affected core subsystem(s)
doc
cc. @guybedford, @bmeck