v8.9.4 proposal #17772
Closed
v8.9.4 proposal #17772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the template for the global object is explicitly marked as hidden. This is unnecessary since the global object is automatically marked as hidden by V8. Getting rid of this call gets rid of the last use of SetHiddenPrototype. PR-URL: #16554 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #16863 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017 PR-URL: #16941 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
PR-URL: #16951 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Tests a basic WebAssembly module that adds two numbers. wasm example from the WebAssembly/wabt repo licensed Apache 2.0. Refs: https://github.com/WebAssembly/wabt/blob/49b7984544ddaf14d5e2f1ad9115dad7e9a2b299/demo/wat2wasm/examples.js#L27-L32 PR-URL: #16760 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Currenlty the test target will echo additional information that might not be that useful, for example: make doc-only make[1]: Nothing to be done for `doc-only'. make lint Running JS linter... Running C++ linter... Total errors found: 0 make[2]: Nothing to be done for `lint-md'. Running C++ linter on addon docs... Total errors found: 0 make cctest This commit suggests reducing this to: make -s doc-only make -s lint Running JS linter... Running C++ linter... Running C++ linter on addon docs... Total errors found: 0 make -s cctest PR-URL: #17010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
The motivation for this commit is to enable projects embedding Node.js and building with --enable-static to be able to run the test suite and linter. Currently when building with --enable-static no node executable will be created which means that the tests (apart from the cctest) and linter cannot be run. This is currently a work in progress and works on MacOS but I need to run the CI, and manually on different environments to verify that it works as expected. PR-URL: #14986 Refs: #14158 Refs: #14892 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
The Cpp style guide is growing. IMHO, a Table of Contents makes it easier to navigate. PR-URL: #17052 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Remove commented-out code that is leftover from a refactoring. PR-URL: #17023 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
Make a REPL tab completion test pass in coverage mode by using `Uin` as the common prefix of all `Uint*Array` globals instead of `co` which could be a prefix for `console` and `coverage`, so it doesn't expand the way it's expected to in coverage mode. PR-URL: #17082 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Depending on the allocator, existing code leaks memory. PR-URL: #16898 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Currently the cctest target will fail on linux when configured
--with-dtrace:
/node-v9.2.0/out/Release/obj.target/node/src/node_dtrace.o:
In function `node::DTRACE_NET_SERVER_CONNECTION(
v8::FunctionCallbackInfo<v8::Value> const&)':
node_dtrace.cc:(.text+0x103): undefined reference to
`node_net__server__connection_semaphore'
/node-v9.2.0/out/Release/obj.target/node/src/node_dtrace.o:
In function `node::DTRACE_NET_STREAM_END(
v8::FunctionCallbackInfo<v8::Value> const&)':
...
This is because node_dtrace_provider.o is not linked by the cctest
target.
This commit tries to fix and simplify the conditions in cctest target
so that node_dtrace.o is included for all operating systems that support
dtrace, include node_dtrace_ustack.o for all operating systems except
mac and linux, and include node_dtrace_provider.o for all operating
systems except mac.
PR-URL: #17039
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use an std::unique_ptr for variables that are deleted right after creation. Since the destructor of InspectorTimer is private but needed by the unique_ptr, define deleter_type as friend. PR-URL: #17020 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Add rule for smart pointers, i.e., std::unique_ptr and std::shared_ptr, to the Cpp style guide. Mostly copied from the Google style guide. PR-URL: #17055 Ref: #16970 Ref: #16974 Ref: #17000 Ref: #17012 Ref: #17020 Ref: #17030 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #16923 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Fixes: #13471 PR-URL: #17008 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add a Support section, borrowing heavily from wp-cli project. Move stuff about contributing to Node.js to the bottom as vastly more users are interested in using Node.js and getting help with Node.js than contributing to Node.js. Information still belongs, just not at the top. (Many people will know to look in CONTRIBUTING.md anyway.) PR-URL: #16533 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #17108 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #16703 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
test-https-server-keep-alive-timeout relies on server timeouts and whatnot that will be inherently unreliable on a busy host. The test fails when run with a high `-j` value and higher `--repeat` value passed to `tools/test.py`. Move the test to `sequential`. PR-URL: #16775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Use a unique file name for each benchmark. Running benchmarks simultaneously may be a bit of an unusual use case, but there are use cases, such as stress testing `test/parallel/test-benchmark-fs.js`. PR-URL: #16776 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Add sections about first time contributions, code reviews and seeking consensus, waiting for approvals, testing and CI * Move paragraphs to more suitable sections * Update table of contents * Document the fast-tracking process PR-URL: #17056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #17107 Refs: https://en.wikipedia.org/w/index.php?title=IPv6_address&type=revision&diff=809494791&oldid=804196124 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #17070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe>
PR-URL: #17049 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking. PR-URL: #17031 Refs: nodejs/help#970 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #16996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #17522 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #17553 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
autocannon appears to have trouble recognizing URLs that contain true or false within them. Use 0 or 1 instead to represent the same. PR-URL: #17583 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
- Remove redundant `hasCrypto` checks - Use `common.mustCall()` - Use arrow functions - Deduplicate HTTP & HTTPS code PR-URL: #17562 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17572 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17572 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17572 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #17572 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Add a comment explaining the test (especailly why it forks 80 processes. Use destructuring and an arrow function callback. PR-URL: #17596 Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Use common/fixtures module instead of common.fixturesDir. PR-URL: #17400 Backport-PR-URL: #17770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Remove common.fixturesDir. All tests now use the the common/fixtures module instead. PR-URL: #17400 Backport-PR-URL: #17770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Remove the practice of starting most error descriptions with "Used when" or wordier variations. Change errors of the form: > Used when the type of an asynchronous resource is invalid. ...to: > The type of an asynchronous resource was invalid. Change errors of the form: > The `'ERR_INVALID_CURSOR_POS'` is thrown specifically when a cursor on > a given stream is attempted to move to a specified row without a > specified column. ...to: > A cursor on a given stream cannot be moved to a specified row without > a specified column. PR-URL: #16954 Backport-PR-URL: #17767 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This is mostly an excuse to remind people that it's "V8" and not "v8" when referring to the JavaScript engine. PR-URL: #17163 Backport-PR-URL: #17765 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #17163 Backport-PR-URL: #17765 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #17163 Backport-PR-URL: #17765 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
nodejs-github-bot
added
build
|
D'oh, wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits
c1b02b90e6] - tools/doc: add tools/remark-* to eslintignore (Ivan Wei) #172408fd61e12ac] - (SEMVER-MINOR) async_wrap: add provider types for net server (Andreas Madsen) #17157e93a6dab62] - benchmark: fix http/simple.js benchmark (Anatoli Papirovski) #17583bf84ed0b75] - benchmark: set maxHeaderListPairs in h2 headers.js (Anatoli Papirovski) #171943fc70502b7] - benchmark: use unique filenames in fs benchmarks (Rich Trott) #167765d6fd0d687] - benchmark,path: remove unused variables (薛定谔的猫) #15789c544194008] - build: allow running configure from any directory (Gibson Fahnestock) #173219c93b97169] - build: define HAVE_OPENSSL macro for cctest (Matheus Marchini) #17461fa107ddbf4] - build: add serial commas to messages in configure script (Rich Trott) #17464a6c7030dd6] - build: fix test-v8 target (Michaël Zasso) #1726991dfd90e4b] - build: add make lint-js-fix (Joyee Cheung) #17283986e4396ef] - build: fix bsd build with gcc (Matheus Marchini) #16737c2e3a10667] - build: remove empty VCLibrarianTool entry (Daniel Bevenius) #1719172e253572b] - build: Allow linking against an external copy of nghttp2. (Ed Schouten) #167882c62ff9a92] - build: do not build doc in source tarball (Joyee Cheung) #171004d8568765c] - build: minor corrections to configure descriptions (Daniel Bevenius) #17094f0fb1d4dff] - build: enforce order of dependency when building addons (Joyee Cheung) #17048bb5a3aa585] - build: fix cctest target --with-dtrace (Daniel Bevenius) #170390348dad25f] - build: prevent echoing of recipes for test target (Daniel Bevenius) #170108dddc7e609] - build: fix cctest compilation (Daniel Bevenius) #1688780abd6433d] - build,win: vcbuild refactoring call configure (Refael Ackermann) #1729988a4d04e70] - crypto: do not reach into OpenSSL internals for ThrowCryptoError (David Benjamin) #16701befb163c3f] - crypto: use SetNull instead of Set (Daniel Bevenius) #1752164164c7e0f] - crypto: make createXYZ inlineable (Matteo Collina) #16067c57cd9bf8b] - deps: V8: cherry-pick cfc3404f from upstream (Ali Ijaz Sheikh) #17354f34ee5c954] - deps: V8: backport 14ac02c from upstream (Ali Ijaz Sheikh) #17512f34ae2666e] - doc: use "JavaScript" instead of "Javascript" (Rich Trott) #17163d23df03191] - doc: prepare for v8/V8 linting in doc text (Rich Trott) #17163fcb8b915e3] - doc: add capitalization styling to STYLE_GUIDE (Rich Trott) #171638bab2db601] - doc: make error descriptions more concise (Rich Trott) #16954329f3de8ad] - doc: fix modules.md export example (Anatoli Papirovski) #17579042ae4ac47] - doc: add link to debugger in process.md (Delapouite) #175228e4cb1bbca] - doc: simplify and clarify FIPS text in BUILDING.md (Rich Trott) #175385e12a9c0ab] - doc: esm loader example with module.builtinModules (Guy Bedford) #17385889986a382] - doc: 'constructor' implies use of new keyword (Cameron Moorehead) #17364fdb216aff1] - doc: add "Hello world" example for N-API (Franziska Hinkelmann) #17425fd9c8b37b5] - doc: immprove inode text in fs.md (Rich Trott) #175194658545f9a] - doc: improve text for Console constructor (Rich Trott) #17519947d3d2603] - doc: improve readability of README.md (Rich Trott) #175198d1a48a664] - doc: improve readability of COLLABORATOR_GUIDE.md (Rich Trott) #17519feb6de5347] - doc: add info on post-publishing ARM6 builds (Michael Dawson) #174554035686966] - doc: mention node-test-pull-request-lite job (Jon Moss) #17513d40c581180] - doc: fix typo in repl.md (Rich Trott) #17502069fd2345b] - doc: fix common typo involving one-time listeners (Rich Trott) #17502533cc5cd74] - doc: fix typo in dns.md (Rich Trott) #17502e5153557a9] - doc: remove unused link reference (Anatoli Papirovski) #175104980517c0c] - doc: remove IPC channel implementation details (Bartosz Sosnowski) #1746085ef4295b7] - doc: update AUTHORS list (Michaël Zasso) #17452fadb297c90] - doc: use serial comma in tls.md (Rich Trott) #17464ecbe2eb621] - doc: add serial comma in CPP_STYLE_GUIDE.md (Rich Trott) #1746477c2c1a9d2] - doc: edit module introduction (Rich Trott) #17463b26f9d64c6] - doc: standardize preposition usage in fs.md (Rich Trott) #174633831e297d4] - doc: improve punctuation in fs.open() text (Rich Trott) #17463e7ae8ae8f5] - doc: use colon consistently in assert.md (Rich Trott) #17463541062c9a5] - doc: update example in module registration (Franziska Hinkelmann) #17424073822f0b5] - doc: introduce categories to Cpp style guide (Franziska Hinkelmann) #17095ebcede3912] - doc: add missing serial commas (Rich Trott) #173848f1db7010b] - doc: be concise about serial commas (Rich Trott) #1738489c1959ca4] - doc: document tls.checkServerIdentity (Hannes Magnusson) #1720388ae46d682] - doc: improve checkServerIdentity docs (Hannes Magnusson) #172036789663bd0] - doc: add guide to maintaining npm (Myles Borins) #165414155216c61] - doc: fix doc example for cctest (Matheus Marchini) #173558c2707b16e] - doc: clarify fast-track of reversions (Refael Ackermann) #17332a20b774dd4] - doc: fix typo in stream.md (Matthew Leon) #17357a2c82c386b] - doc: non-partitioned async crypto operations (Jamie Davis) #17250af7d7a4d34] - doc: move Code of Conduct to admin repo (Myles Borins) #173013a9a5d857a] - doc: fix typo occuring -> occurring (Leko) #17350e722ddd485] - doc: Add link for ECMAScript 2015 (smatsu-hl) #1731751e660ae2a] - doc: caution against removing pseudoheaders (James M Snell) #17329c5fdc53016] - doc: replace string with template string (Leko) #1731677368fc337] - doc: replace function with arrow function in vm.md (narirou) #173078009513992] - doc: replace function with arrow function (Leko) #1730410bf5706ab] - doc: fix typo in api doc of url.format(urlObject) (pkovacs) #17295ae5a870816] - doc: add ES Modules entry to who-to-cc (Rich Trott) #1720523cfef1b11] - doc: add maclover7 to collaborators (Jon Moss) #1728926500b7a63] - doc: update http URLs to https in README.md (Ronald Eddy Jr) #17264f65fee089a] - doc: update http URLs to https in doc/api (Ronald Eddy Jr) #172635ed2d3be65] - doc: update http URLs to https in GOVERNANCE.md (Ronald Eddy Jr) #172621ffa2f6137] - doc: update http URLs to https in CONTRIBUTING.md (Ronald Eddy Jr) #17261cdb7d24af0] - doc: add SharedArrayBuffer to Buffer documentation (Thomas den Hollander) #15489dcab0de197] - doc: document resolve hook formats (Lucas Azzola) #16375ed9296dc85] - doc: fs.readFile is async but not partitioned (Jamie Davis) #171548441632008] - doc: use better terminology for build machines (Anna Henningsen) #171421ac3a4408a] - doc: update mgol in AUTHORS.txt, add to .mailmap (Michał Gołębiowski-Owczarek) #17239aab0a03bd0] - doc: update release table in V8 guide (Ali Ijaz Sheikh) #1713669861cd8a2] - doc: add guybedford to collaborators (Guy Bedford) #17197d106c028fb] - doc: update AUTHORS list (Michaël Zasso) #1657196bf44a2f3] - doc: normalize ToC indentation with heading levels in README (Rich Trott) #1710644562dd651] - doc: add Contributing to Node.js to the README ToC (Rich Trott) #17106cb430a716a] - doc: merge Working Groups with Contributing to Node.js in README (Rich Trott) #171066558363165] - doc: remove IRC node-dev link from README (Rich Trott) #17106be088b9fc2] - doc: add missing introduced_in comments (Luigi Pinca) #16741333537a950] - doc: change v8 to V8 (Rich Trott) #17089a69dcc0ac1] - doc: avoid mentioning 'uncaughtException' (Luigi Pinca) #16905d748e4aa63] - doc: add note about using cluster without networking (pimlie) #17031ff1da17e36] - doc: explicitly document highWaterMark option (Sebastian Silbermann) #17049254d1b7ebf] - doc: fix a link in dgram.md (Vse Mozhet Byt) #171070f37ff1645] - doc: reorganize collaborator guide (Joyee Cheung) #170566d5620d333] - doc: delete unused definition in README.md (Vse Mozhet Byt) #17108fe514a709d] - doc: add Support section in README (Rich Trott) #16533d738c6bf0a] - doc: document common pattern for instanceof checks (Michael Dawson) #16699f30fcdb002] - doc: mention smart pointers in Cpp style guide (Franziska Hinkelmann) #170550bbeb8cd03] - doc: add Table of Contents to Cpp style guide (Franziska Hinkelmann) #17052d07403de8a] - doc: add hashseed to collaborators (Yang Guo)071ecd6ea1] - doc: make stream.Readable consistent (Sakthipriyan Vairamani (thefourtheye)) #167869df93c4533] - doc: correct effects to affects (gowpen) #1679497689c6cf8] - doc: correct EventEmitter reference (gowpen) #16791b8561c2261] - doc: fix a typo in n-api documentation (Vipin Menon) #168794ede5eceb7] - doc: fix typos in N-API (Swathi Kalahastri) #169112af1bf5ce8] - doc,test: remove unnecessary await with return instances (Rich Trott) #17265019d1a385a] - doc,win: clarify WSL support (João Reis) #17008f63acdb407] - errors,tools: ASCIIbetical instead of alphabetical (Refael Ackermann) #1557843697289ba] - fs: use arrow functions instead of.bindandself(Weijia Wang) #171372d7e03fc3f] - http: do not assign intermediate variable (Jon Moss) #17335673e2637f8] - http2: use more descriptive names (James M Snell) #173289fd0b32c38] - http2: remove unnecessary event handlers (James M Snell) #1732831cdbd636a] - http2: reduce code duplication in settings (James M Snell) #17328bdcbe81ad0] - http2: general cleanups (James M Snell) #1732833d04fd766] - inspector: no async tracking for promises (Anna Henningsen) #1711831e21e7d8e] - inspector: include node_platform.h header (Alexey Kuzmin) #16677b1bfcedb7b] - internal: add emitExperimentalWarning function (Cody Deckard) #164977737d118a9] - lib: replace string concatenation with template (Vijayalakshmi Kannan) #16923281a3304f5] - module: fix for Imported modules are undefined if also used inside loader #17130 shared loader cjs dep (Guy Bedford) #17131da404173a8] - module: be lazy when creating CJS facades (Bradley Farias) #1715388e6b590c1] - n-api: use nullptr instead of NULL in node_api.cc (Daniel Bevenius) #17276eb7285dfa2] - path: remove obsolete comment (Rich Trott) #170239540c8036e] - src: remove unused include node_crypto_clienthello (Daniel Bevenius) #1754694d9f20bbf] - src: fix missing handlescope bug in inspector (Ben Noordhuis) #175399f73ce0f22] - src: node_http2_state.h should not be executable (Jon Moss) #17408ecb78e6289] - src: fix typo in NODE_OPTIONS whitelist (Evan Lucas) #173690d5075ff57] - src: make base64.h self-contained (Daniel Bevenius) #1717778a9aaac5f] - src: add napi_handle_scope_mismatch to msg list (neta) #17161096bd538e8] - src: fix compiler warning (cjihrig) #17195e90c836387] - src: remove unprofessional slang in assertions (Alexey Orlenko) #17166fe1ceb9842] - src: inspector context name = program title + pid (Ben Noordhuis) #17087cbe1e5cf80] - src: abstract getpid() operation (Ben Noordhuis) #17087ad5f2d2f6f] - src: use unique_ptr for http2_state (Franziska Hinkelmann) #17078d4e420749c] - src: use std::unique_ptr in base-object-inl.h (Franziska Hinkelmann) #170793e62c38ab0] - src: fix size of CounterSet (Witthawat Piwawatthanapanit) #1698444d5ecf388] - src: use smart pointer instead of new and delete (Franziska Hinkelmann) #17020826e718509] - src: perf_hooks: fix wrong sized delete (Ali Ijaz Sheikh) #16898728e57b64e] - src: implement backtrace-on-abort for windows (Anna Henningsen) #16951aef08343a9] - src: remove unnecessary call to SetHiddenPrototype (Toon Verwaest) #165549ec35c583f] - src: clean up uv_fs_t's in module_wrap.cc (cjihrig) #1672281970f87ed] - src: fix UB in InternalModuleReadFile() (Ben Noordhuis) #16871b1802ede3b] - src: turn inspector raw pointer into unique_ptr (Franziska Hinkelmann) #16974af579907de] - src: fix bad sizeof expression (Ben Noordhuis) #1701435310437e8] - stream: use arrow fns for 'this' in readable (Vipin Menon) #16927c6a6a7a2c6] - test: remove fixturesDir from common module (Rich Trott) #174000666968071] - test: remove common.fixturesDir from tests (Rich Trott) #17400c7891c4125] - test: refactor test-child-process-pass-fd (Rich Trott) #17596a4ddb0cf49] - test: refactor test-http-default-port (Anna Henningsen) #17562b72677629a] - test: refactored to remove unnecessary variables (Mithun Sasidharan) #17553fb33231abc] - test: use Countdown in http-agent test (Federico Kauffman) #1753732adb70851] - test: update http test to use common.mustCall (Collins Abitekaniza) #17528d8eea81c7d] - test: improve assert messages in repl-reset-event (Adri Van Houdt) #16836c8220b9037] - test: update test-http-should-keep-alive to use countdown (TomerOmri) #175050c34bce114] - test: fix flaky test-benchmark-es (Rich Trott) #17516ce060b71bc] - test: use Countdown in http test (idandagan1) #17506ed13aac2ab] - test: use Number.isNaN instead of global isNaN (Mithun Sasidharan) #17515964cebfd20] - test: use Countdown in http-response-statuscode (Mandeep Singh) #17327210d860ff7] - test: use Countdown in test-http-set-cookies (Shilo Mangam) #17504f9e0cb2166] - test: Use common.mustCall in http test (sreepurnajasti) #17487b54bc9cd7b] - test: update http test to use Countdown (Francisco Gerardo Neri Andriano) #17477d693dacc78] - test: replace fs.accessSync with fs.existsSync (Leko) #17446e0b6bc781c] - test: fix flaky test-benchmark-querystring (Rich Trott) #1751779f7564019] - test: add common.crashOnUnhandledRejection() (IHsuan) #17247f391d3cad4] - test: refactor code to use common.mustCall (Mithun Sasidharan) #174375b927b2faf] - test: remove hidden use of common.PORT in parallel tests (Rich Trott) #17466e4e1212486] - test: add more settings to test-benchmark-dgram (Rich Trott) #174626dea0f8a1f] - test: add dgram benchmark test (jopann) #17462d12d86eadc] - test: fix flaky test-benchmark-events (Rich Trott) #174720f6ce05785] - test: update test-http-request-dont-override-options to use common.mustCall (Mithun Sasidharan) #17438babb288560] - test: replace assert.throws with common.expectsError (Leko) #17445876966f9c3] - test: use common.mustCall in test-http-malformed-request (Mithun Sasidharan) #174393bfe0e29c7] - test: forbidcommon.mustCall*()in process exit handlers (Rich Trott) #1745352e573d0f2] - test: use Countdown in http test (Mithun Sasidharan) #17436181db331a4] - test: update test-http-response-multiheaders to use countdown (hmammedzadeh) #174190813461129] - test: update test-http-timeout to use countdown (Mithun Sasidharan) #1734111d44c63d0] - test: make common.mustNotCall show file:linenumber (Lance Ball) #17257e6c5255798] - test: update test-http-upgrade-client to use countdown (Mithun Sasidharan) #173399076c27114] - test: update test-http-status-reason-invalid-chars to use countdown (Mithun Sasidharan) #1734250bd4b030e] - test: refactored test-http-allow-req-after-204-res to countdown (Mithun Sasidharan) #17211dbcc378f86] - test: update test/parallel/test-http-pipe-fs.js to use countdown (ChungNgoops) #173467d553746e4] - test: refactored test-http-response-splitting to use countdown (Mithun Sasidharan) #17348dbae582b55] - test: make CreateParams stack-allocated (Daniel Bevenius) #1736677205b73ab] - test: use v8 Default Allocator in cctest fixture (Daniel Bevenius) #17366a27df5d45e] - test: replace function with arrow function (Leko) #17345b016cbbb37] - test: fix flaky async-hooks/test-graph.signal (Rich Trott) #17509f89efbc27d] - test: remove common.tmpDirName (Rich Trott) #17266f5a2cffac6] - test: replace function with ES6 arrow function (Junichi Kajiwara) #1730697888e021d] - test: add es6 module global leakage tests (WhoMeNope) #16341021d7df76b] - test: Enable specifying flaky tests on fips (Nikhil Komawar) #163294ebd75bce9] - test: refactored http test to use countdown (Mithun Sasidharan) #1724180d16712ff] - test: Update test-http-parser-free to use countdown timer (Mandeep Singh) #173224f0cdae0db] - test: Update test-http-client-agent to use countdown timer (Mandeep Singh) #173250b45b42f9d] - test: fix flaky parallel/test-http2-client-upload (Anna Henningsen) #173615ac5663b3d] - test: fix isNAN->Number.isNAN (yuza yuko) #17309cdab6ea5a9] - test: make use of Number.isNaN to test-readfloat.js (Hiromu Yoshiwara) #17310afe4c33db6] - test: replace function with arrow function (spring_raining) #173125eb0c9959f] - test: replace function with arrow function (Hiroaki KARASAWA) #173086b9934142e] - test: replace function with arrow function (kou-hin) #17305610164df12] - test: use arrow function (koooge) #17318d30502ca03] - test: use Number.isNaN() (MURAKAMI Masahiko) #17319f19eab2db6] - test: add test of stream Transform (Yoshiya Hinosawa) #173031fab8fab76] - test: use common.crashOnUnhandledRejection (yozian) #172428c8a2fded4] - test: use common.crashOnUnhandledRejection (Kcin1993) #1723511fd745e93] - test: add common.crashOnUnhandledRejection() (Andy Chen) #17234e73c1918ed] - test: use common.crashOnUnhandledRejection (zhengyuanjie) #17215fa6867de85] - test: use common.crashOnUnhandledRejection (Jason Chung) #1723386955115b0] - test: use common.crashOnUnhandledRejection() (sorarize@gmail.com) #17232474f857cb8] - test: use common.crashOnUnhandledRejection (Kurt Hsu) #17229c95ccfd55d] - test: add common.crashOnHandleRejection (jackyen) #17225eb1f8c50b7] - test: add crashonUnhandledRejection (danielLin) #17237dab1381d27] - test: keep coverage reports after coverage-clean (Anatoli Papirovski) #154705125e6cee5] - test: add test on unhandled rejection (Larry Lu) #172280b8c543c18] - test: use common.crashOnUnhandledRejection (aryung chen) #1722112073eb7e5] - test: use common.crashOnUnhandledRejection (Zack Yang) #17217cf5263907e] - test: add common.crashOnUnhandledRejection() (Scya597) #17212edfa62a23e] - test: remove unlink function which is needless (buji) #171193028fa703a] - test: dont need to remove nonexistent directory (buji) #1711953f9ce9a21] - test: use common.crashOnUnhandledRejection() (Ivan Wei) #172279226e67e74] - test: add common.crashOnUnhandledRejection() (Kyle Yu) #17236a47b55dc09] - test: use crashOnUnhandledRejection (YuLun Shih) #17220764257727a] - test: fix linting error (James M Snell) #172513d86f32950] - test: use common.crashOnUnhandledRejection (jimliu7434) #172319197f0c68d] - test: use crashOnUnhandledRejection (Roth Peng) #1722682393df2aa] - test: use common.crashOnUnhandledRejection (esbb48) #17218a213e51f6b] - test: use arrow function instead of bind (Lance Ball) #172022aacb051d1] - test: use crashOnUnhandledRejection (Chiahao Lin) #17219d328e067ca] - test: use common.crashOnUnhandledRejection (Whien) #17214861082a161] - test: clean up inappropriate language (Gus Caplan) #17170c58c191d46] - test: wrap callback in common.mustCall (suman-mitra) #1717356c9069e2a] - test: remove unused parameter in test-next-tick-error-spin.js (Francois KY) #1718510531087a5] - test: remove unused parameter (Fran Herrero) #171939a91cfcc8a] - test: remove unused variable (Pierre-Loic Doulcet) #171860b86469afd] - test: remove unused variable (Guillaume Flandre) #17187475634ba96] - test: remove unused parameter (François Descamps) #17184c1e294e9b4] - test: remove unused parameter (Xavier Balloy) #1718856afb7f47e] - test: make debugging of inspector-port-zero easier (Gibson Fahnestock) #1668588a5c13236] - test: replace assert.throws w/ common.expectsError (sgreylyn) #170917b9458b809] - test: reduce benchmark cases in test-benchmark-buffer (Rich Trott) #17111c01d934d3d] - test: fs.write() if 3rd argument is a callback, not offset (Patrick Heneise) #1704544bc65eab4] - test: utilize common.mustCall() on child exit (sreepurnajasti) #169960079b944a8] - test: use arrow functions instead of bind (Tobias Nießen) #170707e8d60e28b] - test: move timing-sensitive test to sequential (Rich Trott) #167756411fe2353] - test: make REPL test pass in coverage mode (Anna Henningsen) #17082c69590d315] - test: --enable-static linked executable (Daniel Bevenius) #14986fca180ec0d] - test: add basic WebAssembly test (Steve Kinney) #16760ea1efca16a] - test: flag known flake (Refael Ackermann) #1694149de7872e3] - test: refactor exitedAfterDisconnect test (Rich Trott) #16729131cf42479] - test: add tests for eslint rules (Teddy Katz) #16138927a28126b] - test: fixup test-http2-create-client-secure-session (James M Snell) #17328eb8344b3a9] - test: use default assertion messages (John Byrne) #16808d2b32ce074] - test: add detailed message for assertion failure (Attila Gonda) #1681255bf57dc9a] - test: improve assert messages in napi exception test (Paul Blanche) #1682025ff7bf1cd] - test: improve error emssage reporting in testNapiRun.js (Paul Ashfield) #168212d63b65aed] - test: refactor addons-napi/test_promise/test.js (ka3e) #16814ad331f20bd] - test: add coverage to tty module (cjihrig) #16959bf81c06566] - test,doc: document where common modules go (Gibson Fahnestock) #160894288b967ce] - tools: simplify no-let-in-for-declaration rule (cjihrig) #175724a10cf551f] - tools: simplify buffer-constructor rule (cjihrig) #175727f979a7f5b] - tools: simplify prefer-assert-methods rule (cjihrig) #17572c1fd4874f8] - tools: simplify prefer-common-mustnotcall rule (cjihrig) #175729868ce5fe6] - tools: replace space with \b in regex (Diego Rodríguez Baquero) #17479053eba0b57] - tools: enable no-return-await lint rule (Rich Trott) #17265dc24a781eb] - tools: add Boxstarter script (Bartosz Sosnowski) #17046273bd7f404] - tools: update to ESLint 4.12.0 (cjihrig) #16948f0074266d8] - tools: add lint fixer forrequire-buffer(Bamieh) #17144c5cd4f0d8b] - tools: make doc tool a bit more readable (Tobias Nießen) #1712513b97e77b5] - tools: remove useless function declaration (Tobias Nießen) #171255aff3d250c] - tools: avoid using process.cwd in tools/lint-js (Tobias Nießen) #171212fb6515db5] - tools: use built-in padStart instead of padString (Tobias Nießen) #1712092e0e2ed77] - tools: allow running test.py without configuring (Gibson Fahnestock) #16621e4788cde0a] - tools: fail tests if malformed status file (Rich Trott) #16703962fd757ad] - tools: try installing js-yaml only once (Joyee Cheung) #1666105f221d78a] - tools: add fixer for no-let-in-for-declaration (Weijia Wang) #16642ba73a67d45] - tools: update to ESLint 4.10.0 (cjihrig) #1673828a0c10feb] - tools,test: use Execute instead of check_output (Refael Ackermann) #173815ee05f2187] - tty: refactor exports (cjihrig) #16959b718e45806] - util: fix negative 0 check in inspect (Gus Caplan) #17507cb7739d900] - util: remove check for global.process (Gus Caplan) #17435