-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note about using cluster networking-less #17031
Conversation
|
30ccd24
to
0bf0173
Compare
Thanks, you are probably right. Changed both the commit as the commit message |
@Trott Strange, I received an email with your comment about not thinking that networking is the primary use-case for cluster but don't see your comment listed here on github? The main reason I wrote that networking is the primary use-case is because I have been startled by the current documentation for weeks and @bnoordhuis confirmed this in the referenced nodejs/help issue. Maybe otherwise the Cluster docs could use more of an overhaul then just adding this sentence? Let me give you a few examples of why I think the current documentation is quite ambiguous if networking isn't the primary use-case:
Not sure if this translates correctly to English, but in Dutch we say |
I guess the primary use case for cluster is to attain vertical sclability (in-system) to suppliment any short-comings the single-threaded node has in exploiting the multiple cores in the host, and as the primary use case of node is web workload, the cluster naturally inherited it. Nothing stopping one from using cluster for other purposes such as massive computation in a distributed manner. The doc changes looks good to me, thanks! |
@pimlie OK, you convinced me. I never thought of it that way, but the docs seem to make that assumption. (You didn't see my comment on GitHub because I deleted it immediately after leaving it. I realized I probably wasn't adding a whole lot to the conversation with my question so I deleted it. I guess GitHub sends notifications immediately because the comment was probably there for a matter of seconds. Oh well. Lesson learned.) |
doc/api/cluster.md
Outdated
@@ -109,7 +109,8 @@ will be dropped and new connections will be refused. Node.js does not | |||
automatically manage the number of workers, however. It is the application's | |||
responsibility to manage the worker pool based on its own needs. | |||
|
|||
|
|||
Although the primary use for the cluster module is networking, this module | |||
can also be used for all other master/worker use-cases (without networking). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove "all" as certainly there are use cases where it is not the right choice.
I'd probably strip it down further to:
Although a primary use case for the `cluster` module is networking, it can
also be used for other use cases requiring worker processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sounds better indeed!
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking. Refs: https://github.com/nodejs/help/issues/970a
0bf0173
to
9cf0592
Compare
Updated as per @Trott comments |
Landed in adb7be2, thanks for the PR! 🎉 |
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking. PR-URL: #17031 Refs: nodejs/help#970 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking. PR-URL: #17031 Refs: nodejs/help#970 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking. PR-URL: #17031 Refs: nodejs/help#970 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking. PR-URL: #17031 Refs: nodejs/help#970 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking. PR-URL: #17031 Refs: nodejs/help#970 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Although the primary use-case for the cluster module is networking, the module provides a generic master/worker interface that could also be used if you dont use networking at all. Currently the docs are a bit ambiguous about this as only the primary use-case is ever mentioned, this remark should clarify that the cluster module can also be used without disadvantages if you dont use networking.
Refs: nodejs/help#970
Checklist
Affected core subsystem(s)
doc