-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: prevent echoing of recipes for test target #17010
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Issues and PRs related to build files or the CI.
label
Nov 14, 2017
Currenlty the test target will echo additional information that might not be that useful, for example: make doc-only make[1]: Nothing to be done for `doc-only'. make lint Running JS linter... Running C++ linter... Total errors found: 0 make[2]: Nothing to be done for `lint-md'. Running C++ linter on addon docs... Total errors found: 0 make cctest This commit suggests reducing this to: make -s doc-only make -s lint Running JS linter... Running C++ linter... Running C++ linter on addon docs... Total errors found: 0 make -s cctest
cjihrig
approved these changes
Nov 14, 2017
jasnell
approved these changes
Nov 14, 2017
joyeecheung
approved these changes
Nov 15, 2017
test/arm-fanned failures look unrelatedStarted by upstream project "node-test-commit-arm-fanned" build number 12592
originally caused by:
Started by upstream project "node-test-commit" build number 14034
originally caused by:
Started by upstream project "node-test-pull-request" build number 11442
originally caused by:
Started by user Joyee Cheung
[EnvInject] - Loading node environment variables.
Building remotely on test-requireio_joeyvandijk-debian7-arm_pi2-2 (pi2-raspbian-wheezy) in workspace /home/iojs/build/workspace/git-nodesource-update-reference
java.io.IOException: Failed to mkdirs: /home/iojs/build/workspace/git-nodesource-update-reference
at hudson.FilePath.mkdirs(FilePath.java:1171)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1210)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:566)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:491)
at hudson.model.Run.execute(Run.java:1737)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:421)
Notifying upstream projects of job completion
Finished: FAILURE test/smartos failures look unrelatednot ok 1866 addons-napi/test_conversions/test
---
duration_ms: 0.636
severity: fail
stack: |-
module.js:544
throw err;
^
Error: Cannot find module './build/Release/test_conversions'
at Function.Module._resolveFilename (module.js:542:15)
at Function.Module._load (module.js:472:25)
at Module.require (module.js:585:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/test/addons-napi/test_conversions/test.js:4:14)
at Module._compile (module.js:641:30)
at Object.Module._extensions..js (module.js:652:10)
at Module.load (module.js:560:32)
at tryModuleLoad (module.js:503:12)
at Function.Module._load (module.js:495:3)
...
not ok 1867 addons-napi/test_function/test
---
duration_ms: 0.737
severity: fail
stack: |-
module.js:544
throw err;
^
Error: Cannot find module './build/Release/test_function'
at Function.Module._resolveFilename (module.js:542:15)
at Function.Module._load (module.js:472:25)
at Module.require (module.js:585:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/test/addons-napi/test_function/test.js:6:23)
at Module._compile (module.js:641:30)
at Object.Module._extensions..js (module.js:652:10)
at Module.load (module.js:560:32)
at tryModuleLoad (module.js:503:12)
at Function.Module._load (module.js:495:3)
...
not ok 1868 addons-napi/test_env_sharing/test
---
duration_ms: 0.635
severity: fail
stack: |-
module.js:544
throw err;
^
Error: Cannot find module './build/Release/store_env'
at Function.Module._resolveFilename (module.js:542:15)
at Function.Module._load (module.js:472:25)
at Module.require (module.js:585:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/test/addons-napi/test_env_sharing/test.js:4:18)
at Module._compile (module.js:641:30)
at Object.Module._extensions..js (module.js:652:10)
at Module.load (module.js:560:32)
at tryModuleLoad (module.js:503:12)
at Function.Module._load (module.js:495:3)
... |
Landed in a0b1e2e |
danbev
added a commit
that referenced
this pull request
Nov 16, 2017
Currenlty the test target will echo additional information that might not be that useful, for example: make doc-only make[1]: Nothing to be done for `doc-only'. make lint Running JS linter... Running C++ linter... Total errors found: 0 make[2]: Nothing to be done for `lint-md'. Running C++ linter on addon docs... Total errors found: 0 make cctest This commit suggests reducing this to: make -s doc-only make -s lint Running JS linter... Running C++ linter... Running C++ linter on addon docs... Total errors found: 0 make -s cctest PR-URL: #17010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
Currenlty the test target will echo additional information that might not be that useful, for example: make doc-only make[1]: Nothing to be done for `doc-only'. make lint Running JS linter... Running C++ linter... Total errors found: 0 make[2]: Nothing to be done for `lint-md'. Running C++ linter on addon docs... Total errors found: 0 make cctest This commit suggests reducing this to: make -s doc-only make -s lint Running JS linter... Running C++ linter... Running C++ linter on addon docs... Total errors found: 0 make -s cctest PR-URL: #17010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Currenlty the test target will echo additional information that might not be that useful, for example: make doc-only make[1]: Nothing to be done for `doc-only'. make lint Running JS linter... Running C++ linter... Total errors found: 0 make[2]: Nothing to be done for `lint-md'. Running C++ linter on addon docs... Total errors found: 0 make cctest This commit suggests reducing this to: make -s doc-only make -s lint Running JS linter... Running C++ linter... Running C++ linter on addon docs... Total errors found: 0 make -s cctest PR-URL: #17010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Currenlty the test target will echo additional information that might not be that useful, for example: make doc-only make[1]: Nothing to be done for `doc-only'. make lint Running JS linter... Running C++ linter... Total errors found: 0 make[2]: Nothing to be done for `lint-md'. Running C++ linter on addon docs... Total errors found: 0 make cctest This commit suggests reducing this to: make -s doc-only make -s lint Running JS linter... Running C++ linter... Running C++ linter on addon docs... Total errors found: 0 make -s cctest PR-URL: #17010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currenlty the test target will echo additional information that might
not be that useful, for example:
This commit suggests reducing this to:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
bulid