Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add common.crashOnUnhandledRejection() in test.js #17247

Closed
wants to merge 2 commits into from
Closed

add common.crashOnUnhandledRejection() in test.js #17247

wants to merge 2 commits into from

Conversation

IHsuan
Copy link
Contributor

@IHsuan IHsuan commented Nov 22, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Nov 22, 2017
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

The change to tools/doc/node_modules/js-yaml/index.js will need to be dropped from this PR. It's an errant change caused by the make lint process that recently just started appearing.

@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
maclover7
maclover7 approved these changes Nov 24, 2017
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if changes to tools/doc/node_modules/js-yaml/index.js are removed

@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11712/

commit message needs to be updated as well

@MylesBorins
Copy link
Contributor

MylesBorins commented Dec 6, 2017 •
edited
Loading

landed in 694e7ba

edit: I took the liberty to fix the meta data while landing

@MylesBorins MylesBorins closed this Dec 6, 2017
MylesBorins pushed a commit that referenced this pull request Dec 6, 2017
@IHsuan @MylesBorins
test: add common.crashOnUnhandledRejection()
694e7ba 
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@IHsuan @MylesBorins
test: add common.crashOnUnhandledRejection()
57fe264 
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@IHsuan @MylesBorins
test: add common.crashOnUnhandledRejection()
0754734 
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@IHsuan @gibfahn
test: add common.crashOnUnhandledRejection()
3cf8f98 
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@IHsuan @gibfahn
test: add common.crashOnUnhandledRejection()
79f7564 
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@IHsuan @gibfahn
test: add common.crashOnUnhandledRejection()
f8856ea 
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclover7 maclover7 maclover7 approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@IHsuan @jasnell @MylesBorins @addaleax @maclover7 @gibfahn @nodejs-github-bot