test: use common.crashOnUnhandledRejection #17217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
previously requested changes
Nov 22, 2017
| @@ -1,6 +1,7 @@ | |||
| // Flags: --inspect=0 | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
| common.crashOnUnhandleRejection(); | |||
There was a problem hiding this comment.
can you please move this to line 26 below all the require statements
Deal with crash case for unhandled rejection.
zack9433
force-pushed
the
handle-unhandle-rejection
branch
from
52cd49e to
b0b1af9
Compare
MylesBorins
added
the
code-and-learn
gireeshpunathil
approved these changes
Nov 22, 2017
jasnell
approved these changes
Nov 22, 2017
|
getting this landed.... |
jasnell
pushed a commit
that referenced
this pull request
Nov 22, 2017
Deal with crash case for unhandled rejection. PR-URL: #17217 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in ab99a89. Thank you and congrats on your PR to core! |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Deal with crash case for unhandled rejection. PR-URL: #17217 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Deal with crash case for unhandled rejection. PR-URL: #17217 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Deal with crash case for unhandled rejection. PR-URL: #17217 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Deal with crash case for unhandled rejection. PR-URL: #17217 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with crash case for unhandled rejection.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test