test: move test-http-keepalive-maxsockets to sequential

[Trott]

test-http-keepalive-maxsockets.js will fail if sufficient copies are run
at once. Move to sequential.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test http

[mscdex]

Why does it fail? It's not using a shared port? If it's the setTimeout(), perhaps we should be using the platform timeout variable there?

[Trott]

Why does it fail?

=== release test-http-keepalive-maxsockets ===                    
Path: parallel/test-http-keepalive-maxsockets
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 1 === 2
    at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:54:14)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js
[00:06|% 100|+  31|-   1]: Done                                  
$ tools/test.py -j 32 --repeat 32 test/parallel/test-http-keepalive-maxsockets.js 
=== release test-http-keepalive-maxsockets ===                    
Path: parallel/test-http-keepalive-maxsockets
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 0 === 2
    at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js
=== release test-http-keepalive-maxsockets ===                   
Path: parallel/test-http-keepalive-maxsockets
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 1 === 2
    at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js
=== release test-http-keepalive-maxsockets ===                   
Path: parallel/test-http-keepalive-maxsockets
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 0 === 2
    at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js
=== release test-http-keepalive-maxsockets ===                   
Path: parallel/test-http-keepalive-maxsockets
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 1 === 2
    at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:54:14)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js
=== release test-http-keepalive-maxsockets ===                   
Path: parallel/test-http-keepalive-maxsockets
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 0 === 2
    at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js
=== release test-http-keepalive-maxsockets ===                   
Path: parallel/test-http-keepalive-maxsockets
assert.js:42
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 1 === 2
    at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:54:14)
    at ontimeout (timers.js:478:11)
    at tryOnTimeout (timers.js:302:5)
    at Timer.listOnTimeout (timers.js:262:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js
[00:06|% 100|+  26|-   6]: Done  
$

perhaps we should be using the platform timeout variable there?

IMO anything that needs platformTimeout() should probably be in sequential anyway. (And anything in sequential should be refactored to not have race conditions if possible, of course.)

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/11266/

[Trott]

Landed in 6af68d0