Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9.2.0 proposal #16992

Merged
merged 135 commits into from
Nov 14, 2017
Merged

v9.2.0 proposal #16992

merged 135 commits into from
Nov 14, 2017

Conversation

evanlucas
Copy link
Contributor

2017-11-14, Version 9.2.0 (Current), @evanlucas

Notable Changes

  • crypto:
    • Support building with both 1.1.0 and 1.0.2 (David Benjamin) #16130
  • fs:
    • fs.realpathSync.native and fs.realpath.native are now exposed (Ben Noordhuis) #15776

Commits

  • [02ea0ee507] - build: fix cctest compilation (Daniel Bevenius) #16887
  • [a4557f294a] - build: remove cctest extension (Yihong Wang) #16680
  • [1dc4fc1390] - build: include src/tracing when linting on win (Daniel Bevenius) #16720
  • [4c11801ed7] - build: add missing options to help message (Daniel Bevenius) #16707
  • [bed0560fb5] - console: avoid adding infinite error listeners (Matteo Collina) #16770
  • [31dadd2007] - (SEMVER-MINOR) crypto: deprecate {ecdhCurve: false} (David Benjamin) #16130
  • [f952caa677] - (SEMVER-MINOR) crypto: clear some SSL_METHOD deprecation warnings (David Benjamin) #16130
  • [a5e7255385] - (SEMVER-MINOR) crypto: make ALPN the same for OpenSSL 1.0.2 & 1.1.0 (David Benjamin) #16130
  • [07102ace9e] - (SEMVER-MINOR) crypto: remove deprecated ECDH calls w/ OpenSSL 1.1 (David Benjamin) #16130
  • [627a15f9e5] - (SEMVER-MINOR) crypto: emulate OpenSSL 1.0 ticket scheme in 1.1 (David Benjamin) #16130
  • [8a8ac8ce4d] - (SEMVER-MINOR) crypto: hard-code tlsSocket.getCipher().version (David Benjamin) #16130
  • [c42935b79c] - (SEMVER-MINOR) crypto: add compat logic for "DSS1" and "dss1" (David Benjamin) #16130
  • [5c24fc32c9] - (SEMVER-MINOR) crypto: Make Hmac 1.1.0-compatible (David Benjamin) #16130
  • [fa1fc16c3e] - (SEMVER-MINOR) crypto: make SignBase compatible with OpenSSL 1.1.0 (David Benjamin) #16130
  • [abe3dc48cc] - (SEMVER-MINOR) crypto: make Hash 1.1.0-compatible (David Benjamin) #16130
  • [59acd27409] - (SEMVER-MINOR) crypto: make CipherBase 1.1.0-compatible (David Benjamin) #16130
  • [6c3ae36cab] - (SEMVER-MINOR) crypto: remove locking callbacks for OpenSSL 1.1.0 (David Benjamin) #16130
  • [81760ffea9] - (SEMVER-MINOR) crypto: use RSA and DH accessors (David Benjamin) #16130
  • [568d9d0eac] - (SEMVER-MINOR) crypto: test DH keys work without a public half (David Benjamin) #16130
  • [6a9c528a50] - (SEMVER-MINOR) crypto: account for new 1.1.0 SSL APIs (David Benjamin) #16130
  • [cc744b9b26] - (SEMVER-MINOR) crypto: remove unnecessary SSLerr calls (David Benjamin) #16130
  • [201393f655] - (SEMVER-MINOR) crypto: estimate kExternalSize (David Benjamin) #16130
  • [efd9bc36fa] - (SEMVER-MINOR) crypto: make node_crypto_bio compat w/ OpenSSL 1.1 (David Benjamin) #16130
  • [8da4983cb4] - (SEMVER-MINOR) crypto: use X509_STORE_CTX_new (David Benjamin) #16130
  • [f82d3e44c8] - deps: upgrade libuv to 1.16.1 (cjihrig) #16835
  • [38ac50a084] - deps: cherry-pick cc55747 from V8 upstream (Franziska Hinkelmann) #16890
  • [75405a1481] - deps: ICU 60 bump (Steven R. Loomis) #16876
  • [28b7bf062a] - deps: cherry-pick b8331cc030 from upstream V8 (Daniel Bevenius) #16900
  • [2266cafba5] - Revert "deps: cherry-pick b8331cc030 from upstream V8" (Daniel Bevenius) #16899
  • [81f14bffff] - deps: cherry-pick b8331cc030 from upstream V8 (Daniel Bevenius) #16743
  • [54768f5094] - doc: reorganize COLLABORATOR_GUIDE.md (Rich Trott) #15710
  • [c4e2343bfb] - doc: drop support for VS2015 (Nikolai Vavilov) #16868
  • [74f33724a2] - doc: clarify the prerequisites for building with VS2017 (Nikolai Vavilov) #16903
  • [1510fda1b0] - doc: outline commit message for breaking changes (Maton Anthony) #16846
  • [1fcd95e517] - doc: remove duplicate 'the' from http2 API doc (Vipin Menon) #16924
  • [b46714c023] - doc: fix typos in N-API (Swathi Kalahastri) #16911
  • [3ba52c1582] - doc: correct the spelling of omitting in dgram.md (Vidya Subramanyam) #16910
  • [e60eff6c01] - doc: fix a typo in the documentation (Mamatha J V) #16909
  • [6e9973e912] - doc: improve documentation for the vm module (Franziska Hinkelmann) #16867
  • [15dcb96b28] - doc: fix a typo in n-api documentation (Vipin Menon) #16879
  • [928647c77c] - doc: fix typo in assert.md (Andres Kalle) #16866
  • [a184dbcb2c] - doc: update subprocess.killed (cjihrig) #16748
  • [8611e3b93b] - (SEMVER-MINOR) fs: expose realpath(3) bindings (Ben Noordhuis) #15776
  • [8dfd5a515a] - http2: multiple smaller code cleanups (James M Snell) #16764
  • [8245e5a2d4] - http2: simplify subsequent rstStream calls (Anatoli Papirovski) #16753
  • [afbdd017c1] - lib: replace string concatenation with template (Suryanarayana Murthy N) #16933
  • [6c0fd55488] - lib: guard inspector console using process var (Daniel Bevenius) #15008
  • [c1792544e8] - lib: improve the usage of TypeError[INVALID_ARG_TYPE] (Weijia Wang) #16401
  • [44c3cc2bec] - lib: change concatenated string to template (Pawan Jangid) #16930
  • [8eb32e1b35] - lib: replace String concatenation with template (saiHemak) #16922
  • [678e738d70] - lib: change concatenated string to template (Nayana Das K) #16925
  • [df181745b8] - lib: replace string concatenation with template (Jayashree S Kumar) #16921
  • [a9358068db] - lib: replace string concatenation with template (Chandrakala) #16920
  • [16c622209a] - lib: replace string concatenation with template (subrahmanya chari p) #16917
  • [64a0c80773] - loader: test search module (Cyril Lakech) #16795
  • [79648496ec] - src: explain implementation of vm module (Franziska Hinkelmann) #16962
  • [a79d86db21] - src: use unrefed async for GC tracking (Anna Henningsen) #16758
  • [5df3dc1169] - src: make StreamBase prototype accessors robust (Joyee Cheung) #16860
  • [41937bedf9] - src: add process.ppid (cjihrig) #16839
  • [0b93bbb419] - src: add openssl-system-ca-path configure option (Daniel Bevenius) #16790
  • [43c5726028] - src: fix UB in InternalModuleReadFile() (Ben Noordhuis) #16871
  • [bce5db2225] - src: CHECK() for argument overflow in Spawn() (cjihrig) #16761
  • [ad02676816] - test: used fixturesDir from fixtures modules (Klemen Kogovsek) #16813
  • [809dc099ac] - test: refactor fs.write() test (Patrick Heneise) #16827
  • [35fc317d8f] - test: add a test description (Grant Gasparyan) #16833
  • [83f9604adc] - test: use ES6 classes instead of util.inherits (Tobias Nießen) #16938
  • [7c364a269c] - test: use common/fixtures module in hash-seed test (Javier Blanco) #16823
  • [3136578871] - test: make test-tls-external-accessor agnostic (Rich Trott) #16272
  • [0be7f8c48c] - test: make test-require-json engine agnostic (Rich Trott) #16272
  • [835ca63595] - test: make test-repl engine agnostic (Rich Trott) #16272
  • [f8337cea8e] - test: make test-repl-syntax-error-stack agnostic (Rich Trott) #16272
  • [c81b086928] - test: make test-repl-harmony engine agnostic (Rich Trott) #16272
  • [591a6927ee] - test: make test-querystring-escape engine agnostic (Rich Trott) #16272
  • [e2f564821e] - test: make test-process-env-symbols agnostic (Rich Trott) #16272
  • [9bf887475e] - test: make test-os-eol engine agnostic (Rich Trott) #16272
  • [79e183186c] - test: make error stack test engine agnostic (Rich Trott) #16272
  • [b5b23bd3e8] - test: make test-http-outgoing-proto agnostic (Rich Trott) #16272
  • [bd7822b8f6] - test: make test-error-reporting engine agnostic (Rich Trott) #16272
  • [4604294647] - test: make test-console engine agnostic (Rich Trott) #16272
  • [025eadfcd5] - test: make test-console-count engine agnostic (Rich Trott) #16272
  • [c74467f938] - test: make test-cli-syntax engine agnostic (Rich Trott) #16272
  • [2e2e8020e7] - test: make test-buffer-slow engine agnostic (Rich Trott) #16272
  • [7a5378377f] - test: improve template value for test message (Stephan Smith) #16826
  • [6ea8768141] - test: unmark flaky test (Anna Henningsen) #16758
  • [651fee4c54] - test: change concatenated string to template (Deepthi Sebastian) #16929
  • [1ea546c9ee] - test: change concatenated string to template (Anawesha Khuntia) #16912
  • [385f65826a] - test: change string concatenation to template (Suryanarayana Murthy N) #16919
  • [61fbd857d7] - test: use template string for concatenation (Vipin Menon) #16918
  • [fbec5ec4d9] - test: replace string concatenation with template (Kabir Islam) #16916
  • [407eb6f93e] - test: enable mustCall() during child exit (Vipin Menon) #16915
  • [26e4c587eb] - (SEMVER-MINOR) test: fix flaky test-http2-create-client-connect (David Benjamin) #16130
  • [8c294203cf] - (SEMVER-MINOR) test: fix test-https-agent-session-eviction for 1.1 (David Benjamin) #16130
  • [3d438f84b2] - (SEMVER-MINOR) test: configure certs in tests (David Benjamin) #16130
  • [08ac21423e] - (SEMVER-MINOR) test: revise test-tls-econnreset for OpenSSL 1.1.0 (David Benjamin) #16130
  • [d95b608d98] - (SEMVER-MINOR) test: test with a larger RSA key (David Benjamin) #16130
  • [85ffc2f960] - (SEMVER-MINOR) test: remove sha from test expectations (David Benjamin) #16130
  • [bec042183c] - (SEMVER-MINOR) test: update test expectations for OpenSSL 1.1.0 (David Benjamin) #16130
  • [b42013c31e] - test: replace string concatenation with template (Sabari Lakshmi Krishnamoorthy) #16914
  • [fbc7451553] - test: replace string concatenation with template (Tanvi Kini) #16913
  • [7f7dec8b08] - test: cover vm.runInNewContext() (cjihrig) #16906
  • [8311561ed5] - test: improve assertion messages (Neil Vass) #16885
  • [1ee6df9612] - test: pass process.env to child processes (Rod Vagg) #16405
  • [172652ba27] - test: improve assert messages in stream test (Katie Stockton Roberts) #16884
  • [271c89e569] - test: improve assertion in test-require-dot (Adam Wegrzynek) #16805
  • [5d3a4ad1cf] - test: improve error emssage reporting in testNapiRun.js (Paul Ashfield) #16821
  • [f71f41d79b] - test: add values to error message (Adam Jeffery) #16831
  • [c1cdc658c0] - test: replace common.fixtiresDir with fixtures.readKey() (woj) #16817
  • [c662cc0b70] - test: use internet.addresses in internet tests (Joyee Cheung) #16390
  • [a465f2bc78] - test: introduce test/common/internet.addresses (Joyee Cheung) #16390
  • [bc19a93093] - test: use tmpDir in test-fs-utimes (Rich Trott) #16774
  • [4d55a1dc2f] - test: improve assert messages in napi exception test (Paul Blanche) #16820
  • [8ad4f768c0] - test: remove message argument in cluster setup test (mbornath) #16838
  • [21e9888237] - test: check session timeout in http2 (Anatoli Papirovski) #16754
  • [be266bdbbd] - test: move test-http-keepalive-maxsockets to sequential (Rich Trott) #16777
  • [adcaddfce8] - test: improve assert messages in test-global (Mark McNelis) #16843
  • [7ba35995a7] - tools: fix inspector-check reporting (Daniel Bevenius) #16902
  • [25dd8f66be] - tools: add direct anchors for error codes (Joyee Cheung) #16779
  • [625999b840] - tools: don't lint files that have not changed (Joyee Cheung) #16581
  • [942a9ed6a8] - tools,build: allow build without remark-cli (Refael Ackermann) #16893

markmcnelis and others added 30 commits November 13, 2017 07:59
PR-URL: #16843
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
test-http-keepalive-maxsockets.js will fail if sufficient copies are run
at once. Move to sequential.

PR-URL: #16777
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Two instances of a similar test exist, with both testing the timeout on
the stream and neither on the session. Adjust one of them to test the
session timeout instead.

PR-URL: #16754
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Do not call destroy each time rstStream is called since the
first call (or receipt of rst frame) will always trigger
destroy. Expand existing test for this behaviour.

PR-URL: #16753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
In test/parallel/test-cluster-setup-master-cumulative.js:

Remove the message parameter to ensure that the compared
objects are printed out. Add the original message as a
comment above.

PR-URL: #16838
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit adds checks for overflow to args and env in Spawn().
It seems extremely unlikely that either of these values would
overflow from a valid use case.

Fixes: #15622
PR-URL: #16761
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit changes the wording of subprocess.killed to reflect
that a child process was successfully signaled, and not
necessarily terminated.

Fixes: #16747
PR-URL: #16748
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16866
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Include unexpected value in assertion messages.

PR-URL: #16820
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit add missing options to the Windows help message and
removes options that no longer exist (test-uv).

PR-URL: #16707
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test-fs-utimes was doing some tests against __filename. This made the
test unreliable when multiple copies were run simultaneously. In
general, tests should use files in either the tmp directory or else
fixtures, so change to using `common.tmpDir` instead. Each copy of the
test (if using `test.py` harness for parallel runs) will use its own
directory, making the test robust again.

PR-URL: #16774
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
PR-URL: #16581
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #16879
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit introduces test/common/internet.address, which
includes a set of addresses for doing internet tests.
These addresses can be overriden using NODE_TEST_* environment
variables.

PR-URL: #16390
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16390
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
If the console destination is a unix pipe (net.Socket), write() is
async. If the destination is broken, we are adding an 'error' event
listener to avoid a process crash. This PR makes sure that we are adding
that listener only once.

Fixes: #16767

PR-URL: #16770
Fixes: #16767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Use fixtures module in test/parallel/test-tls-js-stream.js.

PR-URL: #16817
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
In test-require-extensions-main, include the values that caused the test
to fail in the messages reporting the failure.

PR-URL: #16831
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16821
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This adds direct anchors for the error codes in errors.html.
For example, previously the anchor for ERR_ASSERTION
is #errors_err_assertion, now there is also #ERR_ASSERTION.

PR-URL: #16779
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Include the value that differed from the expected value in an assertion
message in test-require-dot.

PR-URL: #16805
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
In test-stream-pipe-await-train-manual-resume, include unexpected value
in error messages.

PR-URL: #16884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Original commit message:

    I believe the paths to the V8 include headers are incorrect. The
    paths to other sources seem to be relative to the parent directory.

    When building Node.js I get the following warning on Windows:
    Warning: Missing input files:
    deps\v8\src\..\..\include\v8-inspector-protocol.h
    deps\v8\src\..\..\include\v8-inspector.h

    This commit updates the two include paths.

    Bug:
    Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f
    Reviewed-on: https://chromium-review.googlesource.com/743981
    Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49121}

PR-URL: #16743
Fixes: #16614
Refs: v8/v8@b8331cc
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This reverts commit 4e769a8.

The reason for reverting this is that I forgot to increment the
v8_embedder_string in the above commit.

PR-URL: #16899
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Make the `uv_fs_realpath()` binding (which calls the libc `realpath()`
on UNIX and `GetFinalPathNameByHandle()` on Windows) available as the
`fs.realpath.native()` and `fs.realpathSync.native()` functions.

The binding was already available as `process.binding('fs').realpath`
but was not exposed or tested - and partly broken as a result.

Fixes: #8715
PR-URL: #15776
Refs: #7899
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Original commit message:

    I believe the paths to the V8 include headers are incorrect. The
    paths to other sources seem to be relative to the parent directory.

    When building Node.js I get the following warning on Windows:
    Warning: Missing input files:
    deps\v8\src\..\..\include\v8-inspector-protocol.h
    deps\v8\src\..\..\include\v8-inspector.h

    This commit updates the two include paths.

    Bug:
    Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f
    Reviewed-on: https://chromium-review.googlesource.com/743981
    Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49121}

This commit also increments the v8_embedder_string version.

PR-URL: #16900
Fixes: #16614
Refs: v8/v8@b8331cc
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
`&vec[0]` is undefined behavior when `vec.size() == 0`.

It is mostly academic because package.json files are not usually empty
and because with most STL implementations it decays to something that
is legal C++ as long as the result is not dereferenced, but better safe
than sorry.

Note that the tests don't actually fail because of that, I added them
as sanity checks.

PR-URL: #16871
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>
Add an intro section and example for the vm module.

PR-URL: #16867
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
For variables such as LD_LIBRARY_PATH and DYLD_LIBRARY_PATH that are
needed for dynamically linked binaries

PR-URL: #16405
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack and others added 12 commits November 14, 2017 14:21
PR-URL: #16723
Refs: nodejs/build#885
Refs: nodejs/nodejs.org#1446
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Update tools/doc/html.js and tools/eslint-rules/crypto-check.js to
remove unused trailing function arguments in preparation for enabling a
lint rule to enforce that practice.

PR-URL: #16953
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Use linting to enforce that the final argument for a function must be
used.

PR-URL: #16953
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* remove custom messages for assert that conceal values
* add comment explaining test
* add block scoping

PR-URL: #16814
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* remove comment that isn't relevant/important
* add comment that explains what the test does

PR-URL: #16829
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Use a unique pointer to make ownership clear.

PR-URL: #16974
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

PR-URL: #16958
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Original commit message:

  [map] Fix map constructor to correctly throw.

  We need to throw before rethrowing, otherwise the exception does
  not trigger a debugger event and is not reported if uncaught.

  R=gsathya@chromium.org, jgruber@chromium.org

  Bug: v8:7047
  Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6
  Reviewed-on: https://chromium-review.googlesource.com/758372
  Reviewed-by: Jakob Gruber <jgruber@chromium.org>
  Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
  Commit-Queue: Yang Guo <yangguo@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#49237}

PR-URL: #16897
Fixes: #16856
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #16842
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
With improvements in V8, using separate emit functions is no longer
necessary and can instead be replaced by the spread operator.

improvement                             confidence        p.value
events/ee-emit.js n=2000000                 2.98 %        0.09852489
events/ee-emit-2-args.js n=2000000          4.19 %    *** 0.0001914216
events/ee-emit-6-args.js n=2000000         61.69 %    *** 6.611964e-35
events/ee-emit-diff-args.js n=2000000      -0.36 %        0.305069
events/ee-once.js n=20000000                6.42 %    *** 1.27831e-06

PR-URL: #16869
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Notable changes:

* **crypto**:
  - Support building with both 1.1.0 and 1.0.2 (David Benjamin) #16130
* **fs**:
  - fs.realpathSync.native and fs.realpath.native are now exposed (Ben Noordhuis) #15776
* **process**:
  - expose process.ppid (cjihrig) #16839

PR-URL: #16992
@evanlucas
Copy link
Contributor Author

Added some more commits. New CI: https://ci.nodejs.org/job/node-test-pull-request/11437/

@bricss #16931 hasn't landed yet, so I excluded it. I did pull in the other though. About to start building binaries and will cut provided CI is happy

@MylesBorins
Copy link
Contributor

@evanlucas
Copy link
Contributor Author

Ah thanks @MylesBorins!

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 14, 2017

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing of significance in CitGM

@evanlucas evanlucas merged commit 930f7a6 into v9.x Nov 14, 2017
@evanlucas evanlucas deleted the v9.2.0-proposal branch November 14, 2017 23:07
@refack
Copy link
Contributor

refack commented Nov 14, 2017

CitGM new fails:

evanlucas added a commit that referenced this pull request Nov 14, 2017
Notable changes:

* **crypto**:
  - Support building with both 1.1.0 and 1.0.2 (David Benjamin) #16130
* **fs**:
  - fs.realpathSync.native and fs.realpath.native are now exposed (Ben Noordhuis) #15776
* **process**:
  - expose process.ppid (cjihrig) #16839

PR-URL: #16992
@cjihrig
Copy link
Contributor

cjihrig commented Nov 14, 2017

shot should be fixed already. It just needed a new version published to npm.

evanlucas added a commit to evanlucas/nodejs.org that referenced this pull request Nov 14, 2017
evanlucas added a commit to nodejs/nodejs.org that referenced this pull request Nov 14, 2017
@rvagg
Copy link
Member

rvagg commented Nov 16, 2017

@evanlucas there is a armv6l in staging now, could you promote it and update the release blog post please?

@evanlucas
Copy link
Contributor Author

Done. Thanks for the reminder @rvagg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.