Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "deps: cherry-pick b8331cc030 from upstream V8" #16899

Closed
wants to merge 1 commit into from
Closed

Revert "deps: cherry-pick b8331cc030 from upstream V8" #16899

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 9, 2017

This reverts commit 4e769a8.

The reason for reverting this is that I forgot to increment the
v8_embedder_string in the above commit.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@danbev
Revert "deps: cherry-pick b8331cc030 from upstream V8"
df6c1ef 
This reverts commit 4e769a8.

The reason for reverting this is that I forgot to increment the
v8_embedder_string in the above commit.
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Nov 9, 2017
@bnoordhuis
Copy link
Member

@danbev Just go ahead and land that now, no need to wait 48 hours.

@danbev
Copy link
Contributor Author

danbev commented Nov 9, 2017

Just go ahead and land that now, no need to wait 48 hours.

Will do, thanks!

@danbev
Copy link
Contributor Author

danbev commented Nov 9, 2017

Landed in 3393b65

@danbev danbev closed this Nov 9, 2017
danbev added a commit that referenced this pull request Nov 9, 2017
@danbev
Revert "deps: cherry-pick b8331cc030 from upstream V8"
3393b65 
This reverts commit 4e769a8.

The reason for reverting this is that I forgot to increment the
v8_embedder_string in the above commit.

PR-URL: #16899
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@danbev @evanlucas
Revert "deps: cherry-pick b8331cc030 from upstream V8"
2266caf 
This reverts commit 4e769a8.

The reason for reverting this is that I forgot to increment the
v8_embedder_string in the above commit.

PR-URL: #16899
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
Merged
@danbev danbev deleted the revert-v8-fix-include-path branch November 16, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danbev @bnoordhuis @targos @MylesBorins @nodejs-github-bot