test: add a test description for test/parallel/test-cluster-fork-env.js

[grantgasp]

Add value to assertion message to test-cluster-fork-env.js test

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

Test

[vsemozhetbyt]

It seems we are lacking spaces here and using unnecessary concatenation and redundant templates. What if we use something like this?

    assert.ok(
      checks.using,
      `The worker did not receive the correct env. ${checks.using}`);
    assert.ok(
      checks.overwrite,
      `The custom environment did not overwrite the existing environment. ${
        checks.overwrite}`);

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/11272/

[Trott]

Hi @grantgasp! Welcome and thanks for the PR!

Given that we can be certain the values checked are booleans, I'm not sure that adding this info to the messages is helpful. This is an error in the task I curated and not anything you did. I'm terribly sorry about that.

However, there are definitely things that can be done to improve this test.

I'd recommend removing the changes you did and instead adding a comment (below the declaration of common) that indicates the purpose of the test. Something like "This test checks that arguments provided to cluster.fork() will create new environment variables and override existing environment variables in the created worker process."

Would you mind doing that? I know it's not much of a change, but it's an improvement, and as a first contribution, it will allow you to see how our process works.

[gireeshpunathil]

Landed in 707e71c , thanks for the contribution!