Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fs.write() if 3rd argument is a callback, not offset #16822

Closed
wants to merge 4 commits into from
Closed

test: fs.write() if 3rd argument is a callback, not offset #16822

wants to merge 4 commits into from

Conversation

PatrickHeneise
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
mscdex
mscdex reviewed Nov 6, 2017
View reviewed changes
test/parallel/test-fs-write.js Outdated

fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) {
assert.ifError(err);
console.log('open done');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these console statements can be left out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2017
@gireeshpunathil gireeshpunathil added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 6, 2017
cjihrig
cjihrig approved these changes Nov 6, 2017
View reviewed changes
test/parallel/test-fs-write.js Outdated
fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) {
assert.ifError(err);
const done = common.mustCall(function(err, written) {
assert.strictEqual(Buffer.byteLength(expected), written);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an assert.ifError(err); here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

PatrickHeneise pushed a commit to PatrickHeneise/node that referenced this pull request Nov 15, 2017
test: fs.write() if 3rd argument is a callback, not offset; easier wa…
7e3635f 
…y to resolve conflicts from nodejs#16822 and nodejs#16827
@PatrickHeneise PatrickHeneise mentioned this pull request Nov 15, 2017
Closed
3 tasks
@PatrickHeneise
Copy link
Author

New PR without conflicts #17045

addaleax pushed a commit that referenced this pull request Nov 18, 2017
@addaleax
test: fs.write() if 3rd argument is a callback, not offset
8f8999c 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins
test: fs.write() if 3rd argument is a callback, not offset
79ba863 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@gibfahn
test: fs.write() if 3rd argument is a callback, not offset
c01d934 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gibfahn
test: fs.write() if 3rd argument is a callback, not offset
2f276c8 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PatrickHeneise @mscdex @jasnell @cjihrig @gireeshpunathil @nodejs-github-bot