Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fs.write() if 3rd argument is a callback, not offset #16822

Closed
wants to merge 4 commits into from
Closed

test: fs.write() if 3rd argument is a callback, not offset #16822

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae52749
test: fs.write() if 3rd argument is a callback, not offset
Nov 6, 2017
e901ee9
lint: newline eof
Nov 6, 2017
7d7d9a9
remove console.log
Nov 6, 2017
de5febc
add assert.ifError()
Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/parallel/test-fs-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,14 @@ fs.open(fn2, constants.O_CREAT | constants.O_WRONLY | constants.O_TRUNC, 0o644,
assert.strictEqual(expected, found);
}));
}));


fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) {
assert.ifError(err);
console.log('open done');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these console statements can be left out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

const done = common.mustCall(function(err, written) {
assert.strictEqual(Buffer.byteLength(expected), written);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an assert.ifError(err); here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

fs.closeSync(fd);
});
fs.write(fd, expected, done);
}));