-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: properly handle already closed stream error #17942
Conversation
Ping @nodejs/http2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit
array[pos] = val; | ||
} | ||
|
||
class Frame { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some comments on how to use these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
6ac0bfd
to
f714aac
Compare
CI is good |
PR-URL: #17942 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #17942 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
HTTP/2 RFC requires connection to be torn down if the client attempts to use an already closed stream ID.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
http2