changed comment that was wrong in _steram_readable.js #19882
Conversation
nodejs-github-bot
added
the
stream
lib/_stream_readable.js
Outdated
| @@ -302,7 +302,8 @@ function chunkInvalid(state, chunk) { | |||
| } | |||
|
|
|||
|
|
|||
| // if it's past the high water mark, we can push in some more. | |||
| // It simply checks the the state length with high water mark | |||
There was a problem hiding this comment.
The previous sentence stated that we could push more if we were past the highWaterMark.
I would like to have a similar sentence there.
This function returns the result of .push().
lib/_stream_readable.js
Outdated
| @@ -302,7 +302,8 @@ function chunkInvalid(state, chunk) { | |||
| } | |||
|
|
|||
|
|
|||
| // if it's past the high water mark, we can push in some more. | |||
| // It simply checks the the state length with high water mark | |||
| // which will return true if we are below the watermark | |||
| // Also, if we have no data yet, we can stand some | |||
There was a problem hiding this comment.
no it isn't missing period made it more clear in the latest commit
lib/_stream_readable.js
Outdated
| // if it's past the high water mark, we can push in some more. | ||
| // It simply checks the state length with high water mark | ||
| // and will return true if we are below the watermark. | ||
| // We can also push more code if were past the highWaterMark. |
There was a problem hiding this comment.
We can also push more code if were past the highWaterMark.
Are you sure about this? If we are past the highWaterMark, this will return false, according to our docs this should signal "please stop".
There was a problem hiding this comment.
yes we can't push more update the complete comment and making is similar to the previous one
There was a problem hiding this comment.
ok thanks, done the changes
lib/_stream_readable.js
Outdated
| @@ -302,7 +302,7 @@ function chunkInvalid(state, chunk) { | |||
| } | |||
|
|
|||
|
|
|||
| // if it's past the high water mark, we can push in some more. | |||
| // We can push more code if are below the highWaterMark. | |||
There was a problem hiding this comment.
sorry made changes now everything looks good please review
lib/_stream_readable.js
Outdated
| @@ -302,7 +302,7 @@ function chunkInvalid(state, chunk) { | |||
| } | |||
|
|
|||
|
|
|||
| // if it's past the high water mark, we can push in some more. | |||
| // We can push more code if we are below the highWaterMark. | |||
There was a problem hiding this comment.
may you please elaborate
There was a problem hiding this comment.
pushing "more code" is not very clear.
|
@vsnehil92 would you be so kind and address the comment? Otherwise this should be good to go. |
|
Updating more code to more data |
|
updated the comment sorry for the delay |
PR-URL: #19882 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in e76831b |
PR-URL: #19882 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#19882 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This is the PR with respect to the issue #19695 @mcollina please review the comment.