Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed comment that was wrong in _steram_readable.js #19882

Closed
wants to merge 7 commits into from
Closed

changed comment that was wrong in _steram_readable.js #19882

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e2329f
changed comment that was wrong in _steram_readable.js
vsnehil92 Apr 8, 2018
d7889ca
updated comment and corrected the typo
vsnehil92 Apr 9, 2018
411966c
updated comment
vsnehil92 Apr 9, 2018
69d7d23
removed the updates and made it similar to previous one
vsnehil92 Apr 9, 2018
2142851
made grammatically correct
vsnehil92 Apr 9, 2018
4ea3234
made grammatically correct
vsnehil92 Apr 9, 2018
8989b9a
updated code to data to make it clear
vsnehil92 Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ function chunkInvalid(state, chunk) {
}


// if it's past the high water mark, we can push in some more.
// It simply checks the the state length with high water mark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: the the

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous sentence stated that we could push more if we were past the highWaterMark.
I would like to have a similar sentence there.
This function returns the result of .push().

// which will return true if we are below the watermark
// Also, if we have no data yet, we can stand some
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it isn't missing period made it more clear in the latest commit

// more bytes. This is to work around cases where hwm=0,
// such as the repl. Also, if the push() triggered a
Expand Down