test,tools: refactor custom ESLint for readability

[Trott]

Refactor the test and the source for the lowercase-name-for-primitive
custom ESLint rule for readability.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[lpinca]

Are we moving to trailing commas?

[Trott]

Are we moving to trailing commas?

@lpinca We use both styles in the code base. I would never block or even nit anyone else's PRs about it, but yes, I try to add trailing-commas when the opportunity presents itself.

FWIW, right now on master, if we change the comma-dangle rule to this…:

    'comma-dangle': ['error', {
      arrays: 'always-multiline',
      objects: 'only-multiline',
    }],

…we get 689 lines to change across 367 files. That's not something I'd want to do in a single comma-dangle PR but also something that seems achievable over enough time. (We've done it for other rules.)

In #19133, it seemed agreed that this approach (change when you can if you're already in there for other reasons) was a reasonable approach.

[lpinca]

I'm not suggesting to enable the rule or blocking this for such a nuance, I was only only interested to know if any decision was made about that. In a recent PR discussion (I'll try to find it and link here) some collaborators, me included, were not very happy with trailing commas.

[lpinca]

Refs: #20703 (comment)

[Trott]

@lpinca I suspect you mean the voting on this comment: #20703 (comment)

You, tniessen, and cjihrig went for "no trailing comma".

A little later on, bnoordhuis, targos, and mmarchini seemed to be in favor of it (definitely bnoordhuis, and inferring the other two from the GitHub reactions on #20703 (comment)).

Dangling-comma vs. no-dangling-comma may finally be impossible for the project to resolve unlike the venerable tabs vs. spaces and semicolons vs. no-semicolons.

[Trott]

I was only only interested to know if any decision was made about that.

In that case: Definitely not. No decision has been made.

[Trott]

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/814/

[Trott]

Landed in cdd2e96