test: add fs.watchFile() + worker.terminate() test #21179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
fs
apapirovski
approved these changes
Jun 6, 2018
Fishrock123
approved these changes
Jun 6, 2018
hiroppy
approved these changes
Jun 7, 2018
benjamingr
approved these changes
Jun 7, 2018
cjihrig
approved these changes
Jun 7, 2018
|
Getting related CI failures like https://ci.nodejs.org/job/node-test-commit-linuxone/1994/nodes=rhel72-s390x/testReport/junit/(root)/test/parallel_test_worker_fs_stat_watcher/: out/Release/node[29153]: ../src/node_worker.cc:307:virtual node::worker::Worker::~Worker(): Assertion `(uv_loop_close(&loop_)) == (0)' failed.
1: node::Abort() [out/Release/node]
2: 0x15084c4 [out/Release/node]
3: node::worker::Worker::~Worker() [out/Release/node]
4: node::Environment::RunCleanup() [out/Release/node]I’ll look into it. |
|
Ok, so, this seems to expose a libuv bug, and I see no way of hacking around that. Guess this PR will have to wait for now. |
trivikr
approved these changes
Jun 8, 2018
JungMinu
approved these changes
Jun 8, 2018
jasnell
approved these changes
Jun 10, 2018
addaleax
force-pushed
the
worker-fs-watch-file
branch
from
a03e9bf
to
3f00235
Compare
|
With libuv 1.27.0 (#26707) merged, this should now finally be ready! |
addaleax
added
author ready
|
Landed in d398e89 🎉 |
addaleax
added a commit
that referenced
this pull request
Mar 18, 2019
Refs: #21093 (comment) PR-URL: #21179 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Refs: nodejs#21093 (comment) PR-URL: nodejs#21179 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Refs: #21093 (comment) PR-URL: #21179 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
Refs: #21093 (comment) PR-URL: #21179 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
@BethGriggs I think this is causing failures in v10.x-staging because it depends on #26707… I think either this has to be removed or the libuv update has to be included in v10.x as well |
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Refs: #21093 (comment) PR-URL: #21179 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #21093 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes