Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v11.13.0 release proposal #26949

Merged
merged 164 commits into from
Mar 28, 2019
Merged

v11.13.0 release proposal #26949

merged 164 commits into from
Mar 28, 2019

Conversation

targos
Copy link
Member

@targos targos commented Mar 27, 2019 •
edited
Loading

2019-03-28, Version 11.13.0 (Current), @targos

Notable Changes

  • crypto
    • Allow deriving public from private keys (Tobias Nießen) #26278.
  • events
    • Added a once function to use EventEmitter with promises (Matteo Collina) #26078.
  • tty
    • Added a hasColors method to WriteStream (Ruben Bridgewater) #26247.
    • Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485.
  • v8
    • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (James M Snell) #26501.
  • worker
    • Added worker.moveMessagePortToContext. This enables using MessagePorts in different vm.Contexts, aiding with the isolation that the vm module seeks to provide (Anna Henningsen) #26497.
  • C++ API
    • AddPromiseHook is now deprecated. This API was added to fill an use case that is served by async_hooks, since that has Promise support (Anna Henningsen) #26529.
    • Added a Stop API to shut down Node.js while it is running (Gireesh Punathil) #21283.
  • meta

Commits

  • [a2d2756792] - assert: reduce internal usage of public require of util (toshi1127) #26750
  • [db7c4ac40b] - assert: reduce internal usage of public require of util (Daiki Ihara) #26762
  • [3ab438aa17] - benchmark: replace deprecated and eliminate var in buffer-from.js (gengjiawen) #26585
  • [0e4ae00676] - benchmark: use gfm for clarity (gengjiawen) #26710
  • [509ad40348] - build: restore running tests on Travis (Richard Lau) #26720
  • [b480c792be] - build: temporarily don't run tests on Travis (Richard Lau) #26720
  • [4163864be5] - build: use Xenial and gcc 6 on Travis (Richard Lau) #26720
  • [e39a468cdc] - child_process: ensure message sanity at source (Gireesh Punathil) #24787
  • [f263f98d5a] - console: remove unreachable code (Rich Trott) #26863
  • [e49cd40789] - console: fix trace function (Ruben Bridgewater) #26764
  • [f2a07df27f] - crypto: improve error handling in parseKeyEncoding (Tobias Nießen) #26455
  • [ed7599bf36] - (SEMVER-MINOR) crypto: allow deriving public from private keys (Tobias Nießen) #26278
  • [74c6f57aed] - (SEMVER-MINOR) crypto: expose KeyObject class (Filip Skokan) #26438
  • [54ffe61c56] - deps: upgrade to libuv 1.27.0 (cjihrig) #26707
  • [dae1e301c6] - dgram: remove usage of public require('util') (dnlup) #26770
  • [119f83bb44] - doc: mark settings as optional and add callback (Ruben Bridgewater) #26894
  • [a545cfe293] - doc: edit "How Can I Help?" in Collaborator Guide (Rich Trott) #26895
  • [14cc4f220c] - doc: add option to require 'process' to api docs (dkundel) #26792
  • [977f5acd04] - doc: minor edit to worker_threads.md (Rich Trott) #26870
  • [78e6ec7dd5] - doc: edit LTS material in Collaborator Guide (Rich Trott) #26845
  • [7e072c816c] - doc: change error message to 'not defined' (Mohammed Essehemy) #26857
  • [c7b34cd8ee] - doc: fix comma of the list in worker_threads.md (Hang Jiang) #26838
  • [560ff919b2] - doc: remove discord community (Aymen Naghmouchi) #26830
  • [fc0aa50c3d] - doc: remove How Does LTS Work section from Collaborator Guide (Rich Trott) #26723
  • [bc9f6d877a] - doc: condense LTS material in Collaborator Guide (Rich Trott) #26722
  • [8de9fe94a0] - doc: document error event is optionally emitted after .destroy() (Sergey Zelenov) #26589
  • [148c2ca33d] - doc: add Note of options.stdio into child_process (kohta ito) #26604
  • [0303aba162] - doc: update spawnSync() status value possibilities (Rich Trott) #26680
  • [6744b8cb43] - doc: add ZYSzys to collaborators (ZYSzys) #26730
  • [0c06631a71] - doc: simplify force-push guidelines (Rich Trott) #26699
  • [b38cf49094] - doc: make RFC references consistent (Rich Trott) #26727
  • [1f0a2835f4] - doc: note about DNS ANY queries / RFC 8482 (Thomas Hunter II) #26695
  • [cfa152b589] - doc: simplify Troubleshooting text (Rich Trott) #26652
  • [e8e8eac96c] - doc: update copy/paste error message in Troubleshooting (Rich Trott) #26652
  • [3b471db14a] - doc: add Gireesh to TSC (Rich Trott) #26657
  • [058cf43a3c] - doc: edit "Technical How-To" section of guide (Rich Trott) #26601
  • [9a5c1495b1] - errors: remove usage of require('util') (dnlup) #26781
  • [7022609dcc] - events: load internal/errors eagerly (Joyee Cheung) #26771
  • [df55731918] - (SEMVER-MINOR) events: add once method to use promises with EventEmitter (Matteo Collina) #26078
  • [c96946d5f3] - http: delay ret declaration in method _flushOutput (gengjiawen) #26562
  • [15af5193af] - http2: reduce usage of require('util') (toshi1127) #26784
  • [1073e54ad6] - http2: delete unused enum in node_http2.h (gengjiawen) #26704
  • [3574b62717] - inspector: always set process.binding('inspector').callAndPauseOnStart (Joyee Cheung) #26793
  • [cc4a25a1a9] - lib: lazy load v8 in error-serdes (Richard Lau) #26689
  • [5f3b850da5] - lib: reduce usage of require('util') (dnlup) #26782
  • [bf2b57e46f] - lib: remove usage of require('util') (dnlup) #26779
  • [64a92290c0] - lib: remove usage of require('util') (dnlup) #26777
  • [bff5d301bf] - lib: move extra properties into error creation (Ruben Bridgewater) #26752
  • [e916a2ad54] - lib: remove usage of require('util') (dnlup) #26773
  • [cc76f3f152] - lib: use Array#includes instead of Array#indexOf (Weijia Wang) #26732
  • [a44f98e333] - lib: run prepareMainThreadExecution for third_party_main (Anna Henningsen) #26677
  • [1c1305dbc1] - lib: make lowerProto scope more clear (gengjiawen) #26562
  • [9ce08c85e7] - lib: explicitly initialize debuglog during bootstrap (Joyee Cheung) #26468
  • [b75af1537d] - lib: move format and formatWithOptions into internal/util/inspect.js (Joyee Cheung) #26468
  • [235bb733a6] - module: do not share the internal require function with public loaders (Joyee Cheung) #26549
  • [4cafd7419d] - module: remove usage of require('util') in esm/translators.js (dnlup) #26806
  • [037e3fddfa] - module: remove usage of require('util') in esm/loader.js (dnlup) #26804
  • [414d6f5e04] - module: remove usage of require('util') in cjs/loader.js (dnlup) #26802
  • [fbe6d30bcf] - module: remove usage of require('util') (dnlup) #26805
  • [a20bf75e06] - Revert "net: remove usage of require('util')" (Rich Trott) #26896
  • [5e06c3bc0b] - net: remove usage of require('util') (dnlup) #26807
  • [24e96b24cf] - net: some scattered cleanup (oyyd) #24128
  • [de353b75d5] - perf_hooks: load internal/errors eagerly (Joyee Cheung) #26771
  • [0bd82c93c6] - perf_hooks: reset prev_ before starting ELD timer (Gerhard Stoebich) #26693
  • [c127bec4ab] - policy: reduce internal usage of public util for manifest.js (Jesse Katsumata) #26833
  • [899de0a7c7] - process: check no handle or request is active after bootstrap (Joyee Cheung) #26593
  • [57d302b563] - process: delay creation of process.env after bootstrap/node.js (Joyee Cheung) #26515
  • [255de69596] - process: refactor global.queueMicrotask() (Joyee Cheung) #26523
  • [1481e5b5c1] - process: set the trace category update handler during bootstrap (Joyee Cheung) #26605
  • [be3ea2a1eb] - process: handle node --debug deprecation in pre-execution (Joyee Cheung) #26670
  • [8b65aa73f6] - process: make stdout and stderr emit 'close' on destroy (Matteo Collina) #26691
  • [dd2f2cca00] - process: remove usage of require('util') in per\_thread.js (dnlup) #26817
  • [41761cc4a6] - process: load internal/async_hooks before inspector hooks registration (Joyee Cheung) #26866
  • [b0afac2833] - process: call prepareMainThreadExecution in all main thread scripts (Joyee Cheung) #26468
  • [cf1117a818] - process: move deprecation warning setup for --debug* args (Refael Ackermann) #26662
  • [4200fc30bd] - process: handle process.env.NODE_V8_COVERAGE in pre-execution (Joyee Cheung) #26466
  • [cc606e2dfc] - process: set up process warning handler in pre-execution (Joyee Cheung) #26466
  • [03dba720da] - process: call prepareMainThreadExecution in node inspect (Joyee Cheung) #26466
  • [04e9d5a448] - repl: remove usage of require('util') in repl/history (dnlup) #26819
  • [e8412bc213] - repl: remove redundant initialization (gengjiawen) #26562
  • [5b8eae4ea7] - report: remove duplicate TIME_TYPE (cjihrig) #26708
  • [01778f525b] - report: tidy up included headers (Richard Lau) #26697
  • [5c4187638c] - report: use LocalTime from DiagnosticFilename (Richard Lau) #26647
  • [e3bae20941] - report: use DiagnosticFilename for default filename (Richard Lau) #26647
  • [1b4553401c] - report: remove unnecessary return in setters (Rich Trott) #26614
  • [f50c9c6ae2] - src: move ShouldNotAbortOnUncaughtScope out of Environment (Joyee Cheung) #26824
  • [7e7f07755c] - src: move TrackingTraceStateObserver out of Environment (Joyee Cheung) #26824
  • [bc69a81276] - src: move TickInfo out of Environment (Joyee Cheung) #26824
  • [495e5e9e75] - src: move ImmediateInfo out of Environment (Joyee Cheung) #26824
  • [6de1220cc4] - src: move AsyncCallbackScope out of Environment (Joyee Cheung) #26824
  • [4af9ff00ff] - src: move AsyncHooks out of Environment (Joyee Cheung) #26824
  • [3d9839ba3f] - src: add include guard for trace_event_common.h (gengjiawen) #26883
  • [13eb1d8f8a] - src: store onread callback in internal field (Anna Henningsen) #26837
  • [220f67c6ce] - src: guard exit label when inspector disabled (Daniel Bevenius) #26801
  • [54753f2446] - src: micro-optimize ALPN negotiation (Ben Noordhuis) #26836
  • [6de2437c0f] - src: apply clang-tidy readability-delete-null-pointer (gengjiawen) #26813
  • [de5034643f] - src: apply clang-tidy performance-faster-string-find (gengjiawen) #26812
  • [79d6895484] - src: initialize worker's stack_base_ field (cjihrig) #26739
  • [6911678f9e] - src: use explicit casts to silence conversion warnings (Zach Bjornson) #26766
  • [26361d1a5f] - src: add fast path for equal size to Reallocate() (Anna Henningsen) #26573
  • [f597b37efb] - src: do not make Resize(0)’d buffers base nullptr (Anna Henningsen) #26731
  • [14c3af7f3e] - src: only open HandleScope when necessary (Anna Henningsen) #26734
  • [ad5d8e308c] - src: refactor thread stopping mechanism (Anna Henningsen) #26757
  • [d075814149] - src: replace heap_utils.createHeapSnapshot with v8.getHeapSnapshot (Joyee Cheung) #26671
  • [eafbfadec3] - src: elevate v8 namespaces for PropertyAttribute (gengjiawen) #26681
  • [15ec381944] - src: use EVPKeyPointer in more places (Ben Noordhuis) #26632
  • [2d2b6a8c23] - src: remove unused variable in class InspectorSocketServer (gengjiawen) #26633
  • [3637e71328] - src: use deleted function instead of private function in class AsyncWrap (gengjiawen) #26634
  • [51b8a891d8] - src: inline macro DISALLOW_COPY_AND_ASSIGN (gengjiawen) #26634
  • [6c90b7f259] - (SEMVER-MINOR) src: shutdown node in-flight (Gireesh Punathil) #21283
  • [925b645d60] - src: remove usage of deprecated IsNearDeath (Michaël Zasso) #26630
  • [d0801a1c4a] - (SEMVER-MINOR) src: deprecate AddPromiseHook() (Anna Henningsen) #26529
  • [a13f0a6362] - (SEMVER-MINOR) src: add public API for linked bindings (Anna Henningsen) #26457
  • [1e669b2e2e] - (SEMVER-MINOR) src,lib: make DOMException available in all Contexts (Anna Henningsen) #26497
  • [e044563bb0] - (SEMVER-MINOR) src,lib: allow running multiple per-context files (Anna Henningsen) #26497
  • [8ba0da57a4] - src,win: fix usage of deprecated v8::Object::Set (Michaël Zasso) #26735
  • [249bf509a3] - stream: fix regression introduced in stream: make sure 'readable' is emitted before ending the stream #26059 (Matteo Collina) #26643
  • [0b2f900c9a] - stream: make sure 'readable' is emitted before ending the stream (Matteo Collina) #26059
  • [b552139554] - stream: reduce internal usage of public require of util (Beni von Cheni) #26698
  • [9ef0a295cf] - test: refactor trace event category tests (Joyee Cheung) #26605
  • [5d992f5ef7] - test: delete pummel/test-dtrace-jsstack (Rich Trott) #26869
  • [3cae010ea0] - test: refactor test-https-connect-localport (Rich Trott) #26881
  • [838fb95059] - test: replace localhost IP with 'localhost' for TLS conformity (Rich Trott) #26881
  • [011c205787] - test: use common.PORT instead of hardcoded number (Rich Trott) #26881
  • [4919e4b751] - test: move test-https-connect-localport to sequential (Rich Trot) #26881
  • [57d3ba134a] - test: refactor test-dgram-broadcast-multi-process (Rich Trott) #26846
  • [352c31cd7e] - test: strengthen test-worker-prof (Gireesh Punathil) #26608
  • [963d7d1f4d] - test: move pummel tls test to sequential (Rich Trott) #26865
  • [8ca7d56b2c] - test: fix pummel/test-tls-session-timeout (Rich Trott) #26865
  • [41bd7a62e9] - test: complete console.assert() coverage (Rich Trott) #26827
  • [6874288f6e] - test: fix test-console-stdio-setters to test setters (Rich Trott) #26796
  • [1458711846] - test: remove internal error tests (Ruben Bridgewater) #26752
  • [c535e487d6] - test: refresh tmpdir in child-process-server-close (Luigi Pinca) #26729
  • [7ebd6bdf87] - test: optimize test-http2-large-file (Rich Trott) #26737
  • [9c83002274] - test: use EC cert property now that it exists (Sam Roberts) #26598
  • [ea425140a1] - test: add fs.watchFile() + worker.terminate() test (Anna Henningsen) #21179
  • [2d689888b8] - test: update test for libuv update (cjihrig) #26707
  • [31995e4cd2] - test: fix intrinsics test (Ruben Bridgewater) #26660
  • [c65ff3df6d] - test: fix test-heapdump-worker (Anna Henningsen) #26713
  • [875ddcbf10] - test: remove unnecessary semicolon after macro (Yang Guo) #26618
  • [892282ddb3] - test: whitelist the expected modules in test-bootstrap-modules.js (Richard Lau) #26531
  • [e5312585c1] - (SEMVER-MINOR) test: make cctest full Node.js environment (Anna Henningsen) #26457
  • [00a6f7686e] - test,console: add testing for monkeypatching of console stdio (Rich Trott) #26561
  • [a640834039] - timers: move big impl comment to /internal/ (Jeremiah Senkpiel) #26761
  • [3ec652ad38] - timers: fix refresh inside callback (Anatoli Papirovski) #26721
  • [1f4a5bcc98] - timers: refactor timer callback initialization (Joyee Cheung) #26583
  • [ebb0c2a44e] - timers: reduce usage of public util (Joyee Cheung) #26583
  • [e6367c2da5] - timers: refactor to use module.exports (Joyee Cheung) #26583
  • [92b666a6b7] - tools: windows_boxstarter "choco install python -y" for Python 3 (cclauss) #26424
  • [d80cd50dbc] - tools: remove eslint rule no-let-in-for-declaration (gengjiawen) #26715
  • [fef2a54a4e] - tools: enable getter-return lint rule (cjihrig) #26615
  • [08383a7bb6] - tools: update ESLint to 5.15.3 (cjihrig) #26746
  • [30d7f67e0f] - tools: update ESLint to 5.15.2 (cjihrig) #26687
  • [1385b290ef] - tools: update lint-md.js to lint rfc name format (Rich Trott) #26727
  • [72cda51440] - tools: tidy function arguments in eslint rules (Rich Trott) #26668
  • [0f9a779da8] - trace_events: remove usage of require('util') (dnlup) #26822
  • [83f6ec8876] - tty: remove util.inherits usage (nd-02110114) #26797
  • [8cafd83ba7] - (SEMVER-MINOR) tty: add NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485
  • [070faf0bc1] - (SEMVER-MINOR) tty: add hasColors function (Ruben Bridgewater) #26247
  • [04c7db3638] - url: remove usage of require('util') (toshi1127) #26808
  • [9092e12b82] - (SEMVER-MINOR) v8: integrate node-heapdump into core (James M Snell) #26501
  • [4314dbfce9] - worker: create per-Environment message port after bootstrap (Joyee Cheung) #26593
  • [3c6f12c965] - (SEMVER-MINOR) worker: implement worker.moveMessagePortToContext() (Anna Henningsen) #26497

mcollina and others added 30 commits March 27, 2019 18:16
@mcollina @targos
events: add once method to use promises with EventEmitter
df55731 
This change adds a EventEmitter.once() method that wraps ee.once in a
promise.

Co-authored-by: David Mark Clements <david.mark.clements@gmail.com>

PR-URL: #26078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@joyeecheung @targos
process: call prepareMainThreadExecution in node inspect
03dba72 
Since we should treat the node-inspect as third-party
user code.

Backport-PR-URL: #26662
PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung @targos
process: set up process warning handler in pre-execution
cc606e2 
Since it depends on environment variables.

Backport-PR-URL: #26662
PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung @targos
process: handle process.env.NODE_V8_COVERAGE in pre-execution
4200fc3 
Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.

Backport-PR-URL: #26662
PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack @targos
process: move deprecation warning setup for --debug* args
cf1117a 
PR-URL: #26662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@joyeecheung @targos
lib: move format and formatWithOptions into internal/util/inspect.js
b75af15 
So these can be required without requiring the whole `util.js`.

PR-URL: #26468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung @targos
process: call prepareMainThreadExecution in all main thread scripts
b0afac2 
PR-URL: #26468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung @targos
lib: explicitly initialize debuglog during bootstrap
9ce08c8 
This patch splits the implementation of util.debuglog into a
separate file and explicitly initialize it during pre-execution
since the initialization depends on environment variables.
Also delays the call to `debuglog` in modules that are loaded during
bootstrap to make sure we only access the environment variable
during pre-execution.

PR-URL: #26468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR @targos
tty: add hasColors function
070faf0 
This adds a small wrapper around the `getColorDepth` function to check
if the stream supports at least a specific amount of colors. This is
convenient as the other API is not as straight forward and most use
cases likely only want to know if a specific amount of colors is
supported or not.

PR-URL: #26247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@addaleax @targos
test: make cctest full Node.js environment
e531258 
Make sure `node::Init()` is called once, and execute
`RunBootstrapping()` so that Node’s internals are ready
when the cctests run.

PR-URL: #26457
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax @targos
src: add public API for linked bindings
a13f0a6 
(Re-?)add a public API for creating linked bindings (access to
`NM_F_LINKED` as a constant was previously removed in
d6ac8a4), and add a test for
the functionality.

PR-URL: #26457
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax @targos
src: deprecate AddPromiseHook()
d0801a1 
This API was added to fill an use case that is served by `async_hooks`,
since that has `Promise` support.

Deprecate this, as the underlying `Isolate::SetPromiseHook()` may be
removed in its current form in the future.

Refs: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/

PR-URL: #26529
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell @targos
v8: integrate node-heapdump into core
9092e12 
Adds `v8.writeHeapSnapshot(filename)` with impl adapted
from the `node-heapdump` module.

Also, adds a v8.getHeapSnapshot() alternative that returns
a Readable Stream

PR-URL: #26501
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau @targos
test: whitelist the expected modules in test-bootstrap-modules.js
892282d 
Be explicit on the modules that are expected to be loaded and add an
appropriate assertion failure message to help debug when the list
changes.

Fixes: #23884

PR-URL: #26531
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@Trott @targos
doc: edit "Technical How-To" section of guide
058cf43 
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.

PR-URL: #26601
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@Trott @targos
doc: add Gireesh to TSC
3b471db 
TSC voted in Gireesh today. Add him to the TSC list in the README.

Closes: #26186

PR-URL: #26657
Fixes: #26186
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@Trott @targos
report: remove unnecessary return in setters
1b45534 
Barring shenanigans like Object.getOwnPropertyDescriptor(), return
values from a setter function will always be inaccessible. Remove
the `return` statements as they can be misleading, suggesting that the
return value is accessible and perhaps used somewhere.

PR-URL: #26614
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@oyyd @targos
net: some scattered cleanup
24e96b2 
This commit cleans up net module, including: 1. remove assigning
`handle.readable` and `handle.writable` 2. documents
`NODE_PENDING_PIPE_INSTANCES` enviroment variable 3. use constants
for '0.0.0.0' and '::'.

PR-URL: #24128
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gengjiawen @targos
http: delay ret declaration in method _flushOutput
c96946d 
PR-URL: #26562
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gengjiawen @targos
repl: remove redundant initialization
e8412bc 
PR-URL: #26562
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gengjiawen @targos
lib: make lowerProto scope more clear
1c1305d 
PR-URL: #26562
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos
src: remove usage of deprecated IsNearDeath
925b645 
Refs: v8/v8@06193b0

PR-URL: #26630
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau @targos
report: use DiagnosticFilename for default filename
e3bae20 
PR-URL: #26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau @targos
report: use LocalTime from DiagnosticFilename
5c41876 
PR-URL: #26647
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@Trott @targos
doc: update copy/paste error message in Troubleshooting
e8e8eac 
In the Troubleshooting portion of the Collaborator Guide, there is a
copy/pasted error message. The message is out of date. More recent git
contains a more concise and clear message. Update the text to reflect
the current git error message.

PR-URL: #26652
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@Trott @targos
doc: simplify Troubleshooting text
cfa152b 
In the Troubleshooting section of the Collaborator Guide, there is one
particularly lengthy and difficult-to-understand sentence. Make it
shorter and more clear.

PR-URL: #26652
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@gireeshpunathil @targos
src: shutdown node in-flight
6c90b7f 
This commit introduces a `node::Stop()` API.

An identified use case for embedders is their ability to tear down
Node while it is still running (event loop contain pending events)

Here the assumptions are that (i) embedders do not wish to resort to
JS routines to initiate shutdown (ii) embedders have the Environment
handle handy. (iii) embedders stop Node through a second thread.

Fixes: #19365
Refs: nodejs/user-feedback#51

PR-URL: #21283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
@hashseed @targos
test: remove unnecessary semicolon after macro
875ddcb 
PR-URL: #26618
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott @targos
tools: tidy function arguments in eslint rules
72cda51 
Remove unused arguments from function invocations in ESLint custom
rules.

PR-URL: #26668
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott @targos
test,console: add testing for monkeypatching of console stdio
00a6f76 
lib/internal/console/constructor.js contains setters for console._stdout
and console._stderr but these setters are not used in our tests or in
Node.js core. (This is confirmed by our nightly coverage reports.)

Add a test to check monkeypatching _stdout and _stderr on a console
object.

PR-URL: #26561
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos removed libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21971/

@targos
Copy link
Member Author

targos commented Mar 27, 2019

/cc @nodejs/collaborators @nodejs/release

CI: https://ci.nodejs.org/job/node-test-pull-request/21971/
CITGM: https://ci.nodejs.org/job/citgm-smoker/1780/

mcollina
mcollina approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BridgeAR
BridgeAR approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We mostly added all semver-minor commits to the notable changes: should we do that here as well?

I would at least add:

src: deprecate AddPromiseHook() (Anna Henningsen) #26529

doc/changelogs/CHANGELOG_V11.md Outdated Show resolved Hide resolved
@sam-github sam-github mentioned this pull request Mar 28, 2019
Closed
4 tasks
@targos
2019-03-28, Version 11.13.0 (Current)
29867f3 
Notable changes:

* crypto
  * Allow deriving public from private keys (Tobias Nießen)
    [#26278](#26278).
* events
  * Added a `once` function to use `EventEmitter` with promises
    (Matteo Collina) [#26078](#26078).
* tty
  * Added a `hasColors` method to `WriteStream` (Ruben Bridgewater)
    [#26247](#26247).
  * Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater)
    [#26485](#26485).
* v8
  * Added `v8.getHeapSnapshot` and `v8.writeHeapSnapshot` to generate snapshots
    in the format used by tools such as Chrome DevTools (James M Snell)
    [#26501](#26501).
* worker
  * Added `worker.moveMessagePortToContext`. This enables using MessagePorts in
    different vm.Contexts, aiding with the isolation that the vm module seeks to
    provide (Anna Henningsen)
    [#26497](#26497).
* C++ API
  * `AddPromiseHook` is now deprecated. This API was added to fill an use case
    that is served by `async_hooks`, since that has `Promise` support
    (Anna Henningsen) [#26529](#26529).
  * Added a `Stop` API to shut down Node.js while it is running
    (Gireesh Punathil) [#21283](#21283).
* meta
  * [Gireesh Punathil](https://github.com/gireeshpunathil) is now a member of
    the Technical Steering Committee
    [#26657](#26657).
  * Added [Yongsheng Zhang](https://github.com/ZYSzys) to collaborators
    [#26730](#26730).

PR-URL: #26949
@targos targos force-pushed the v11.13.0-proposal branch from 04903d8 to 29867f3 Compare March 28, 2019 07:05
@targos
Copy link
Member Author

targos commented Mar 28, 2019

I added a few more notable changes

@targos
Copy link
Member Author

targos commented Mar 28, 2019

Release build: https://ci-release.nodejs.org/job/iojs+release/4313/

I'll promote later today.

@panva
Copy link
Member

panva commented Mar 28, 2019

Deleted my previous comment. Only what's in staging branch is slated for release, am i right?

@targos
Copy link
Member Author

targos commented Mar 28, 2019

Yes, but for the Current release line, anything that is not semver-major could be pulled into the staging branch.

@ronkorving
Copy link
Contributor

ronkorving commented Mar 28, 2019 •
edited
Loading

@targos Just a small "typo" in the release notes:

This API was added to fill an use case

Should read:

This API was added to fill a use case

@targos
Copy link
Member Author

targos commented Mar 28, 2019

@ronkorving do you feel strongly about it? I'd have to force-push and rebuild everything to fix it. I can make the fix in the blog post though.

@targos targos merged commit 29867f3 into v11.x Mar 28, 2019
targos added a commit that referenced this pull request Mar 28, 2019
@targos
Working on v11.13.1
26640ce 
PR-URL: #26949
targos added a commit that referenced this pull request Mar 28, 2019
@targos
2019-03-28, Version 11.13.0 (Current)
2c73868 
Notable changes:

* crypto
  * Allow deriving public from private keys (Tobias Nießen)
    [#26278](#26278).
* events
  * Added a `once` function to use `EventEmitter` with promises
    (Matteo Collina) [#26078](#26078).
* tty
  * Added a `hasColors` method to `WriteStream` (Ruben Bridgewater)
    [#26247](#26247).
  * Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater)
    [#26485](#26485).
* v8
  * Added `v8.getHeapSnapshot` and `v8.writeHeapSnapshot` to generate snapshots
    in the format used by tools such as Chrome DevTools (James M Snell)
    [#26501](#26501).
* worker
  * Added `worker.moveMessagePortToContext`. This enables using MessagePorts in
    different vm.Contexts, aiding with the isolation that the vm module seeks to
    provide (Anna Henningsen)
    [#26497](#26497).
* C++ API
  * `AddPromiseHook` is now deprecated. This API was added to fill an use case
    that is served by `async_hooks`, since that has `Promise` support
    (Anna Henningsen) [#26529](#26529).
  * Added a `Stop` API to shut down Node.js while it is running
    (Gireesh Punathil) [#21283](#21283).
* meta
  * [Gireesh Punathil](https://github.com/gireeshpunathil) is now a member of
    the Technical Steering Committee
    [#26657](#26657).
  * Added [Yongsheng Zhang](https://github.com/ZYSzys) to collaborators
    [#26730](#26730).

PR-URL: #26949
targos added a commit to nodejs/nodejs.org that referenced this pull request Mar 28, 2019
@targos
Blog: v11.13.0 release post
4cda873 
Refs: nodejs/node#26949
@targos targos mentioned this pull request Mar 28, 2019
Merged
targos added a commit to nodejs/nodejs.org that referenced this pull request Mar 28, 2019
@targos
Blog: v11.13.0 release post (#2161)
7ec545e 
Refs: nodejs/node#26949
@targos targos deleted the v11.13.0-proposal branch March 28, 2019 19:36
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@targos @BethGriggs
2019-03-28, Version 11.13.0 (Current)
473b162 
Notable changes:

* crypto
  * Allow deriving public from private keys (Tobias Nießen)
    [#26278](#26278).
* events
  * Added a `once` function to use `EventEmitter` with promises
    (Matteo Collina) [#26078](#26078).
* tty
  * Added a `hasColors` method to `WriteStream` (Ruben Bridgewater)
    [#26247](#26247).
  * Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater)
    [#26485](#26485).
* v8
  * Added `v8.getHeapSnapshot` and `v8.writeHeapSnapshot` to generate snapshots
    in the format used by tools such as Chrome DevTools (James M Snell)
    [#26501](#26501).
* worker
  * Added `worker.moveMessagePortToContext`. This enables using MessagePorts in
    different vm.Contexts, aiding with the isolation that the vm module seeks to
    provide (Anna Henningsen)
    [#26497](#26497).
* C++ API
  * `AddPromiseHook` is now deprecated. This API was added to fill an use case
    that is served by `async_hooks`, since that has `Promise` support
    (Anna Henningsen) [#26529](#26529).
  * Added a `Stop` API to shut down Node.js while it is running
    (Gireesh Punathil) [#21283](#21283).
* meta
  * [Gireesh Punathil](https://github.com/gireeshpunathil) is now a member of
    the Technical Steering Committee
    [#26657](#26657).
  * Added [Yongsheng Zhang](https://github.com/ZYSzys) to collaborators
    [#26730](#26730).

PR-URL: #26949
@baby636 baby636 mentioned this pull request Jul 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.