Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variable in class InspectorSocketServer #26633

Closed
wants to merge 1 commit into from
Closed

src: remove unused variable in class InspectorSocketServer #26633

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Mar 13, 2019
@danbev
Copy link
Contributor

danbev commented Mar 15, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21560/

@danbev
Copy link
Contributor

danbev commented Mar 18, 2019

Landed in 0a00933.

@danbev danbev closed this Mar 18, 2019
danbev pushed a commit that referenced this pull request Mar 18, 2019
@gengjiawen @danbev
src: remove unused variable in class InspectorSocketServer
0a00933 
PR-URL: #26633
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@gengjiawen @targos
src: remove unused variable in class InspectorSocketServer
366bd6e 
PR-URL: nodejs#26633
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@gengjiawen @targos
src: remove unused variable in class InspectorSocketServer
2d2b6a8 
PR-URL: #26633
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@gengjiawen @BethGriggs
src: remove unused variable in class InspectorSocketServer
42c26a6 
PR-URL: #26633
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @danbev @eugeneo @nodejs-github-bot