-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: edit "Technical How-To" section of guide #26601
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Mar 12, 2019
|
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct.
Typo in commit message fixed. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2876/ |
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 12, 2019
BethGriggs
approved these changes
Mar 12, 2019
Co-Authored-By: Trott <rtrott@gmail.com>
vsemozhetbyt
added
the
meta
Issues and PRs related to the general management of the project.
label
Mar 12, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 14, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: nodejs#26601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Landed in 107c95d |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: nodejs#26601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: #26601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
Edit the "Technical How-To" section of the Collaborator Guide. Keep wording simple and direct. PR-URL: #26601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
This was referenced May 29, 2019
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the "Technical How-To" section of the Collaborator Guide. Keep
wording simple and direct.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes