Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't assume broadcast traffic is unfiltered #220

Closed
wants to merge 23 commits into from

Commits on Dec 9, 2014

  1. build: do not generate support for libuv's probes

    Dtrace probes were removed from libuv recently, but their usage by node
    was not completely removed, causing build breaks on SmartOS.
    
    Even though the build is working on other platforms, these probes are
    not fired by libuv anymore, so there's no point in using them on these
    platforms too.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Julien Gilli committed Dec 9, 2014
    Configuration menu
    Copy the full SHA
    4dc660e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2014

  1. deps: update libuv to 1.0.2

    PR-URL: nodejs/node-v0.x-archive#8847
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Dec 10, 2014
    Configuration menu
    Copy the full SHA
    20a7088 View commit details
    Browse the repository at this point in the history
  2. test: mark more tests as flaky

    Marking these two tests as flaky, since they have been failing
    intermittenly in recent builds:
    test-debug-signal-cluster
    test-cluster-basic
    orangemocha committed Dec 10, 2014
    Configuration menu
    Copy the full SHA
    8708c7a View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2014

  1. lib,src: fix spawnSync ignoring its 'env' option

    PR-URL: nodejs/node-v0.x-archive#8546
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    juamedgod authored and trevnorris committed Dec 11, 2014
    Configuration menu
    Copy the full SHA
    946cec7 View commit details
    Browse the repository at this point in the history
  2. test: add test for spawnSync() env option

    PR-URL: nodejs/node-v0.x-archive#8845
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig authored and trevnorris committed Dec 11, 2014
    Configuration menu
    Copy the full SHA
    4bba870 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2014

  1. doc: clarify create{Read,Write}Stream fd option

    Clarify the fd option: it is preferred to the path parameter, omits
    the "open" event if given, and is available on WriteStreams as well.
    
    PR-URL: nodejs/node-v0.x-archive#7707
    Fixes: nodejs/node-v0.x-archive#7707
    Fixes: nodejs/node-v0.x-archive#7708
    Fixes: nodejs/node-v0.x-archive#4367
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    benjamincburns authored and chrisdickinson committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    5b9e5bd View commit details
    Browse the repository at this point in the history
  2. zlib: support concatenated gzip files

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: nodejs/node-v0.x-archive#6442
    eendeego authored and chrisdickinson committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    6f6a979 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2014

  1. debugger: fix unhandled error in setBreakpoint

    Fix Interface.setBreakpoint() to correctly handle an attempt to set a
    breakpoint in the current script when there is no current script.
    This usually happens when the debugged process is not paused.
    
    Fixes: nodejs/node-v0.x-archive#6453
    PR-URL: nodejs/node-v0.x-archive#6460
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    bajtos authored and chrisdickinson committed Dec 17, 2014
    Configuration menu
    Copy the full SHA
    e93ff4f View commit details
    Browse the repository at this point in the history
  2. src: fix windows build error

    Fix a Windows-only build error that was introduced in
    commit 1183ba4 ("zlib: support concatenated gzip files").
    
    Rename the NO_ERROR and FAILED enumerations, they conflict
    with macros of the same name in <winerror.h>.
    
    PR-URL: nodejs/node-v0.x-archive#8893
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    bnoordhuis authored and chrisdickinson committed Dec 17, 2014
    Configuration menu
    Copy the full SHA
    93533e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2014

  1. stream: switch _writableState.buffer to queue

    In cases where many small writes are made to a stream
    lacking _writev, the array data structure backing the
    WriteReq buffer would greatly increase GC pressure.
    
    Specifically, in the fs.WriteStream case, the
    clearBuffer routine would only clear a single WriteReq
    from the buffer before exiting, but would cause the
    entire backing array to be GC'd. Switching to [].shift
    lessened pressure, but still the bulk of the time was
    spent in memcpy.
    
    This replaces that structure with a linked list-backed
    queue so that adding and removing from the queue is O(1).
    In the _writev case, collecting the buffer requires an
    O(N) loop over the buffer, but that was already being
    performed to collect callbacks, so slowdown should be
    neglible.
    
    PR-URL: nodejs/node-v0.x-archive#8826
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    chrisdickinson committed Dec 18, 2014
    Configuration menu
    Copy the full SHA
    9158666 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2014

  1. doc: add details for http res/req end callback

    Add documentation for the callback parameter of http.ClientRequest's and
    http.ServerResponse's end methods.
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    JacksonTian authored and Julien Gilli committed Dec 19, 2014
    Configuration menu
    Copy the full SHA
    890baa0 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2014

  1. url: improve parsing speed

    The url.parse() function now checks whether an escapable character is in
    the URL before trying to escape it.
    
    PR-URL: nodejs/node-v0.x-archive#8638
    [trev.norris@gmail.com: Switch to use continue instead of if]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    CGavrila authored and trevnorris committed Dec 30, 2014
    Configuration menu
    Copy the full SHA
    6a03fce View commit details
    Browse the repository at this point in the history
  2. lib: introduce process module

    This makes require('process') always return a reference to the global
    process object.
    
    PR-URL: nodejs#206
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Aleksey Smolenchuk authored and bnoordhuis committed Dec 30, 2014
    Configuration menu
    Copy the full SHA
    d8586ea View commit details
    Browse the repository at this point in the history
  3. doc: util: document --trace-deprecation

    Document the --trace-deprecation flag and the `process` properties that
    affect util.deprecate().
    
    Fixes: nodejs#190
    PR-URL: nodejs#191
    Reviewed-By: Jonathan Ong <me@jongleberry.com>
    bnoordhuis committed Dec 30, 2014
    Configuration menu
    Copy the full SHA
    8b04161 View commit details
    Browse the repository at this point in the history
  4. doc: added TC meeting minutes 2014-12-17

    Closes nodejs#163
    
    PR-URL: nodejs#178
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Bert Belder <bertbelder@gmail.com>
    rvagg authored and piscisaureus committed Dec 30, 2014
    Configuration menu
    Copy the full SHA
    d5c7a97 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2015

  1. build: i18n: add icu config options

    Make "--with-intl=none" the default and add "intl-none" option to
    vcbuild.bat.
    
    If icu data is missing print a warning unless either --download=all or
    --download=icu is set. If set then automatically download, verify (MD5)
    and unpack the ICU data if not already available.
    
    There's a "list" of URLs being used, but right now only the first is
    picked up. The logic works something like this:
    
    * If there is no directory deps/icu,
      * If no zip file (currently icu4c-54_1-src.zip),
        * Download zip file (icu-project.org -> sf.net)
      * Verify the MD5 sum of the zipfile
        * If bad, print error and exit
      * Unpack the zipfile into deps/icu
    * If deps/icu now exists, use it, else fail with help text
    
    Add the configuration option "--with-icu-source=..."
    
    Usage:
      * --with-icu-source=/path/to/my/other/icu
      * --with-icu-source=/path/to/icu54.zip
      * --with-icu-source=/path/to/icu54.tgz
      * --with-icu-source=http://example.com/icu54.tar.bz2
    
    Add the configuration option "--with-icu-locals=...".  Allows choosing
    which locales are used in the "small-icu" case.
    
    Example:
        configure --with-intl=small-icu --with-icu-locales=tlh,grc,nl
    
    (Also note that as of this writing, neither Klingon nor Ancient Greek
    are in upstream CLDR data. Serving suggestion only.)
    
    Don't use hard coded ../../out paths on windows. This was suggested by
    @misterdjules as it causes test failures.  With this fix, "out" is no
    longer created on windows and the following can run properly:
    
        python tools/test.py simple
    
    Reduce space by about 1MB with ICU 54 (over without this patch). Also
    trims a few other source files, but only conditional on the exact ICU
    version used. This is to future-proof - a file that is unneeded now may
    be needed in future ICUs.
    
    Also:
      * Update distclean to remove icu related files
      * Refactor some code into tools/configure.d/nodedownload.py
      * Update docs
      * Add test
    
    PR-URL: nodejs/node-v0.x-archive#8719
    Fixes: nodejs/node-v0.x-archive#7676 (comment)
    [trev.norris@gmail.com small change to test's whitespace and logic]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Jan 3, 2015
    Configuration menu
    Copy the full SHA
    a308395 View commit details
    Browse the repository at this point in the history
  2. doc: added TC meeting minutes 2014-12-30

    closes nodejs#211
    
    PR-URL: nodejs#229
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    rvagg committed Jan 3, 2015
    Configuration menu
    Copy the full SHA
    261706e View commit details
    Browse the repository at this point in the history
  3. docs: update to authors file

    PR-URL: nodejs/node-v0.x-archive#8964
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Jan 3, 2015
    Configuration menu
    Copy the full SHA
    8cfbeed View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2015

  1. net: make connect() input validation synchronous

    Socket.prototype.connect() sometimes throws on bad inputs
    after an asynchronous operation. This commit makes the input
    validation synchronous. This commit also removes some hard
    coded IP addresses.
    
    PR-URL: nodejs/node-v0.x-archive#8180
    Fixes: nodejs/node-v0.x-archive#8140
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    cjihrig committed Jan 4, 2015
    Configuration menu
    Copy the full SHA
    b636ba8 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2015

  1. smalloc: fix bad assert for zero length data

    If the data length passed to smalloc.alloc() the array_length will be
    zero, causing an overflow check to fail. This prevents that from
    happening.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Jan 5, 2015
    Configuration menu
    Copy the full SHA
    372a2f5 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'joyent/v0.12' into v1.x

    I was originally going to do this after the v0.11.15 release, but as
    that release is three weeks overdue now, I decided not to wait any
    longer; we don't want the delta to get too big.
    
    Conflicts:
    	lib/net.js
    	test/simple/simple.status
    
    PR-URL: nodejs#236
    Reviewed-By: Bert Belder <bertbelder@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis committed Jan 5, 2015
    Configuration menu
    Copy the full SHA
    94e1475 View commit details
    Browse the repository at this point in the history
  3. deps: update libuv to 1.2.0

    PR-URL: nodejs#237
    Reviewed-By: Bert Belder <bertbelder@gmail.com>
    Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
    bnoordhuis committed Jan 5, 2015
    Configuration menu
    Copy the full SHA
    eaed2a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2015

  1. test: don't assume broadcast traffic is unfiltered

    parallel/test-dgram-broadcast-multi-process assumes non-local broadcast
    traffic is unfiltered, an assumption that fails with, for example, the
    default Fedora firewall rules.  Use a loopback interface instead.
    
    Fixes: nodejs#219
    PR-URL: nodejs#220
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    52e600a View commit details
    Browse the repository at this point in the history