Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: fix loose set and map comparison #22495

Closed
wants to merge 3 commits into from
Closed

assert: fix loose set and map comparison #22495

wants to merge 3 commits into from

Commits on Aug 23, 2018

  1. assert: fix loose set and map comparison 

    The fast path did not anticipate different ways to express a loose
equal string value (e.g., 1n == '+0001'). This is now fixed with the
downside that all primitives that could theoretically have equal
entries must go through a full comparison.

Only strings, symbols, undefined and null can be detected in a fast
path as those entries have a strictly limited set of possible equal
entries.
    @BridgeAR
    BridgeAR committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    63ea875 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2018

  1. fixup: address comment

    @BridgeAR
    BridgeAR committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    e80c545 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. fixup

    @BridgeAR
    BridgeAR committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    c030f42 View commit details
    Browse the repository at this point in the history