Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: backport 958b761 from upstream V8 #22914

Closed
wants to merge 2 commits into from
Closed

deps: backport 958b761 from upstream V8 #22914

wants to merge 2 commits into from

Conversation

mmarchini
Copy link
Contributor

Original commit message:

[postmortem] add postmortem metadata for symbols

As discussed in nodejs/llnode#156, we need
postmortem metadata for Symbols to properly print Symbol property names
in postmortem debugging tools. Patch suggested by Ben Noordhuis
(nodejs/llnode#156 (comment)).

R=bmeurer@google.com, yangguo@google.com

Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
Reviewed-on: chromium-review.googlesource.com/1205052
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55632}

Refs: v8/v8@958b761

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@mmarchini build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/914/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency. labels Sep 17, 2018
@mmarchini
Copy link
Contributor Author

mmarchini commented Sep 17, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17261/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/17293/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/17329/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/17409/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/17427/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1695/ ✅

@joyeecheung joyeecheung mentioned this pull request Sep 18, 2018
Closed
@mmarchini
deps: backport 958b761 from upstream V8
a98a445 
Original commit message:

    [postmortem] add postmortem metadata for symbols

    As discussed in nodejs/llnode#156, we need
    postmortem metadata for Symbols to properly print Symbol property names
    in postmortem debugging tools. Patch suggested by Ben Noordhuis
    (nodejs/llnode#156 (comment)).

    R=bmeurer@google.com, yangguo@google.com

    Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
    Reviewed-on: https://chromium-review.googlesource.com/1205052
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#55632}

Refs: v8/v8@958b761
@mmarchini
fixup! deps: backport 958b761 from upstream V8
d12c5eb
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2018
@joyeecheung joyeecheung mentioned this pull request Sep 25, 2018
Closed
@danbev
Copy link
Contributor

danbev commented Sep 27, 2018

Re-run of failing node-test-commit-arm-fanned.

@mmarchini
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17656/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1737/ ✅

@mmarchini
Copy link
Contributor Author

Landed in 247ea55

@mmarchini mmarchini closed this Oct 6, 2018
mmarchini added a commit that referenced this pull request Oct 6, 2018
@mmarchini
deps: backport 958b761 from upstream V8
247ea55 
Original commit message:

    [postmortem] add postmortem metadata for symbols

    As discussed in nodejs/llnode#156, we need
    postmortem metadata for Symbols to properly print Symbol property
    names in postmortem debugging tools. Patch suggested by Ben
    Noordhuis
   (nodejs/llnode#156 (comment)).

    R=bmeurer@google.com, yangguo@google.com

    Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
    Reviewed-on: https://chromium-review.googlesource.com/1205052
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55632}

Refs: v8/v8@958b761

PR-URL: #22914
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 6, 2018
@mmarchini @targos
deps: backport 958b761 from upstream V8
afb4b57 
Original commit message:

    [postmortem] add postmortem metadata for symbols

    As discussed in nodejs/llnode#156, we need
    postmortem metadata for Symbols to properly print Symbol property
    names in postmortem debugging tools. Patch suggested by Ben
    Noordhuis
   (nodejs/llnode#156 (comment)).

    R=bmeurer@google.com, yangguo@google.com

    Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
    Reviewed-on: https://chromium-review.googlesource.com/1205052
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55632}

Refs: v8/v8@958b761

PR-URL: #22914
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
@mmarchini @targos
deps: backport 958b761 from upstream V8
e3550f2 
Original commit message:

    [postmortem] add postmortem metadata for symbols

    As discussed in nodejs/llnode#156, we need
    postmortem metadata for Symbols to properly print Symbol property
    names in postmortem debugging tools. Patch suggested by Ben
    Noordhuis
   (nodejs/llnode#156 (comment)).

    R=bmeurer@google.com, yangguo@google.com

    Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
    Reviewed-on: https://chromium-review.googlesource.com/1205052
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55632}

Refs: v8/v8@958b761

PR-URL: #22914
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@mmarchini @jasnell
deps: backport 958b761 from upstream V8
5d44fe6 
Original commit message:

    [postmortem] add postmortem metadata for symbols

    As discussed in nodejs/llnode#156, we need
    postmortem metadata for Symbols to properly print Symbol property
    names in postmortem debugging tools. Patch suggested by Ben
    Noordhuis
   (nodejs/llnode#156 (comment)).

    R=bmeurer@google.com, yangguo@google.com

    Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118
    Reviewed-on: https://chromium-review.googlesource.com/1205052
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55632}

Refs: v8/v8@958b761

PR-URL: #22914
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmarchini @nodejs-github-bot @danbev @jasnell @cjihrig @joyeecheung @addaleax