all: fix typos throughout repository #23302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
gireeshpunathil
approved these changes
Oct 7, 2018
brandon93s
changed the title
|
great findings, thanks! many typos are funny, and reminded me of the kind of mistakes I used to do. It is surprising to note that |
cjihrig
approved these changes
Oct 7, 2018
Trott
approved these changes
Oct 7, 2018
There was a problem hiding this comment.
LGTM. The commit-message lint failure in Travis can be ignored. It's a bug in core-validate-commit and will be fixed when nodejs/core-validate-commit#29 lands and is in a release.
vsemozhetbyt
approved these changes
Oct 7, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
trivikr
approved these changes
Oct 7, 2018
jasnell
approved these changes
Oct 8, 2018
thefourtheye
approved these changes
Oct 8, 2018
Trott
added
fast-track
|
Landed in 13340d4 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Oct 9, 2018
PR-URL: #23302 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
3 tasks
targos
pushed a commit
that referenced
this pull request
Oct 10, 2018
PR-URL: #23302 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23302 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes spelling fixes following a thorough review of the codebase.
The commits are broken up by area (e.g.
benchmark,doc, etc.).Checklist