Add deprecation warning DEP0066

[mroderick]

This PR makes the deprecation for DEP0066 an active deprecation in code.

Hello from NodeConfEU 👋

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[addaleax]

/cc @nodejs/http

[mroderick]

I don't understand why the linter would fail in this case, and the error is a bit odd to me:

/home/travis/build/nodejs/node/.eslintrc.js:20
    } catch {
            ^
SyntaxError: Unexpected token {

The PR doesn't touch .eslintrc.js. Further, line 20 in .eslintrc.js looks different in my branch:

    } catch (err) {

which shouldn't cause a syntax error. 😕

Any ideas on how to resolve this?

[jasnell]

@mroderick... I think that failure may be unrelated to your changes. Will look into it tho

[jasnell]

Btw... This error is generally because node.js 8 is being used by the linter...

[targos]

This was fixed in 8c3f903.

[mroderick]

Thanks 🙏

[mroderick]

Wrong button 🤦

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/18591/

[Trott]

doc/api/deprecations.md needs to be updated to indicate that this is now a Runtime deprecation.

made the doc change

[Trott]

@nodejs/tsc This needs TSC approvals if it is to land.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/18614/

[targos]

Do we have any idea about ecosystem usage of these properties?

[Trott]

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18624/

[Trott]

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18636/

[mroderick]

made the doc change

Thank you. I was going to do that this morning, but you beat me to it 👍

[Trott]

This needs @nodejs/tsc approvals and a CITGM run.

[mcollina]

Some logging frameworks use to need that information to log certain info. I do not know if it's still the case.

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1628/

[refack]

Some logging frameworks use to need that information to log certain info. I do not know if it's still the case.

CITGM: ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1628

@mcollina Just so you won't get 💔 when that job fails, I've restarted it with a workaround for nodejs/citgm#618:
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1630/

[mcollina]

LGTM

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/18863/

[Trott]

Landed in 91748dd.
Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

[mroderick]

Thank you all