tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD

[sam-github]

Add an error code property to invalid secureProtocol method
exceptions.

Node errors are supposed to have a .code property, so use the new C++ errors framework.

@joyeecheung Its not clear to me whether this has to be semver-major. I changed the error type from Error (env->ThrowError()) to TypeError, which would be semver-major. The .message should not have changed. If its possible to make this semver-minor by changing the error type, I will.... then introduce a tiny semver-major PR to change the type to TypeError for future releases.

If any kind of change like this to the errors is semver-major by definition, then I won't bother splitting it up.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1726/pipeline

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/19059/

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/19065/

[Trott]

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19070/ ✔️

[joyeecheung]

LGTM. Regarding semver-ness, I don't feel strongly that this should be semver-major, but it probably doesn't hurt too much to stay on the safe side?

[sam-github]

Is https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/23597/testReport/junit/(root)/test/parallel_test_cli_syntax/ flaky @Trott ? I've seen it fail a couple times lately in TLS PRs that don't seem related, and it usually passes later on retry.

[sam-github]

Last ci was green, despite what github shows above (thanks @Trott for restarting it).

[Trott]

Is https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/23597/testReport/junit/(root)/test/parallel_test_cli_syntax/ flaky @Trott ?

Very much so. Issue tracking it is #24403. If it's particularly irksome, we can mark it flaky in the status file. I'd personally prefer to keep noticing it and gathering information because it's failing in multiple ways, which is interesting. But I have a high tolerance for pain when it comes to re-running CI jobs, so my opinion may not deserve much weight there.

[danbev]

Landed in b05b330.

[sam-github]

OK, not backporting this to 11.x is hurting the backport of TLS1.3 to 11.x.

TLS1.3 tests have many assertions on TLS error's .code property, which were introduced in #25093, which wasn't backported because this wasn't backported.

I propose backporting this to 11.x as semver-minor by changing the type of the error back to Error from TypeError.

The 11.x backport would then flow into 10.x as semver-minor as a pre-req for TLS1.3, so this affects LTS.

@targos @joyeecheung @nodejs/lts do you agree with what I propose?