test: esm loader unknown builtin module #24183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test looks good to me, and we checked with @BridgeAR who believes it is a problem that he has seen and believes it is a bug in Node.js |
mhdawson
added
the
code-and-learn
|
Tests are now passing after fixing the resolve hook following @devsnek advice (#24175 (comment)). |
BridgeAR
approved these changes
Nov 6, 2018
|
@BridgeAR hello, do you know why the CI is failing at the linter phase? It is not indicating a linter error but a CI crash, imho. Thank you for your support. |
|
seems like the version of node on our ci doesn't support catch without a binding wrt Line 20 in 1f6c4ba |
jasnell
approved these changes
Nov 10, 2018
devsnek
approved these changes
Nov 10, 2018
|
Looking forward to see this PR landed :) |
|
@franher - sure, let me run a full CI and then we should be good to go. |
|
landed as 0229e37 , thanks! |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 12, 2018
PR-URL: #24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
PR-URL: #24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New test added as part of code-learn session. It should not land until #24175 is resolved.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes