Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use latest node on travis #24198

Merged
merged 1 commit into from
Nov 7, 2018
Merged

build: use latest node on travis #24198

merged 1 commit into from
Nov 7, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 6, 2018 •
edited
Loading

Our Travis setup asks for the latest node version when running the linter. We're actually ending up with Node 8.9.1. Trying this instead...

Checklist

CI: https://ci.nodejs.org/job/node-test-pull-request/18379/

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1517/pipeline

@richardlau
Copy link
Member

Is this something we should pursue with Travis? 8.9.1 isn't even the latest 8.x LTS.

@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 6, 2018

Is "latest" a recognized value in Travis? I've never seen it used before. If it is documented as a valid value, then we should probably raise the issue to them.

@richardlau
Copy link
Member

richardlau commented Nov 6, 2018 •
edited
Loading

Is "latest" a recognized value in Travis? I've never seen it used before. If it is documented as a valid value, then we should probably raise the issue to them.

Ah good point. https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions says:

The easiest way to specify Node.js versions is to use one or more of the latest releases in your .travis.yml:

  • node latest stable Node.js release
  • iojs latest stable io.js release
  • lts/* latest LTS Node.js release

...
If you need more specific control of Node.js versions in your build, use any version installable by nvm.

@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 6, 2018

Since the Travis linter is currently broken, please 👍 to approve fast tracking.

@cjihrig cjihrig added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2018
@cjihrig cjihrig mentioned this pull request Nov 6, 2018
Closed
3 tasks
@refack
Copy link
Contributor

refack commented Nov 6, 2018

From the dup:
Refs: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions
Refs: http://logs.libuv.org/node-dev/2018-11-06#22:53:21.202

@refack refack added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Nov 6, 2018
@refack refack mentioned this pull request Nov 6, 2018
Merged
3 tasks
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 7, 2018

The linter passed. There were two test failures, but they were both ENOSPC errors due to the system limit for the number of file watchers.

@refack refack mentioned this pull request Nov 7, 2018
Closed
4 tasks
@cjihrig @refack
build: use latest node on travis
8c3f903 
PR-URL: nodejs#24198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack
Copy link
Contributor

refack commented Nov 7, 2018

Fast-tracked with 4 upvotes. Validated with Lite CI + Travis.
Landed in 8c3f903

@refack refack merged commit 8c3f903 into nodejs:master Nov 7, 2018
@cjihrig cjihrig deleted the travis branch November 7, 2018 02:37
targos pushed a commit that referenced this pull request Nov 7, 2018
@cjihrig @targos
build: use latest node on travis
7083b96 
PR-URL: #24198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 8, 2018
Closed
Closed
Closed
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@cjihrig @kiyomizumia
build: use latest node on travis
9403843 
PR-URL: nodejs#24198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@beevelop beevelop mentioned this pull request Nov 15, 2018
Closed
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@cjihrig @codebytere
build: use latest node on travis
7c4269f 
PR-URL: #24198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@cjihrig @MylesBorins
build: use latest node on travis
2983df8 
PR-URL: #24198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@cjihrig @MylesBorins
build: use latest node on travis
5ed39d9 
PR-URL: #24198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @richardlau @refack @addaleax @targos @codebytere