Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: try to use latest node binary for Travis linter #24206

Closed

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 6, 2018

Refs: #24079 (comment)
Refs: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions
Refs: http://logs.libuv.org/node-dev/2018-11-06#22:53:21.202

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack
Copy link
Contributor Author

refack commented Nov 6, 2018

Travis output:

$ export PATH=./node_modules/.bin:$PATH
Updating nvm
nvm.install
nvm install node
Downloading and installing node v11.1.0...
Downloading https://nodejs.org/dist/v11.1.0/node-v11.1.0-linux-x64.tar.xz...
Computing checksum with sha256sum
Checksums matched!
Now using node v11.1.0 (npm v6.4.1)
$ node --version
v11.1.0
$ npm --version
6.4.1
$ nvm --version
0.33.11
0.01s$ node -v
v11.1.0
The command "node -v" exited with 0.
$ make lint
make[1]: Entering directory `/home/travis/build/refack/node'
Running JS linter...
make[1]: Leaving directory `/home/travis/build/refack/node'

/CC @nodejs/testing

@cjihrig
Copy link
Contributor

cjihrig commented Nov 6, 2018

Duplicate of #24198?

@refack
Copy link
Contributor Author

refack commented Nov 6, 2018

ack.

@refack refack closed this Nov 6, 2018
@refack refack deleted the bump-node-version-for-travis-linter branch November 6, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants