Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.14.1 proposal #24711

Merged
merged 4 commits into from
Nov 29, 2018
Merged

v10.14.1 proposal #24711

merged 4 commits into from
Nov 29, 2018

Commits on Nov 29, 2018

  1. win: clarify Boxstarter behavior on install tools 

    Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.

Currently there is no interface that warns the user that Boxstarter
will reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will
need to take action to re-enable UAC manually if they interfere/stop
the script from finishing.

PR-URL: #23987
Fixes: nodejs/Release#369
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @ferventcoder @MylesBorins
    ferventcoder authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    589f0d2 View commit details
    Browse the repository at this point in the history

  2. win: add prompt to tools installation script 

    Fixes: nodejs/Release#369

PR-URL: #23987
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @joaocgreis @MylesBorins
    joaocgreis authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    5d17bf1 View commit details
    Browse the repository at this point in the history

  3. Revert "win,msi: install tools for native modules" 

    This reverts:
	Revision: 257a5e9
	win: add prompt to tools installation script

	Revision: e9a2915
	win: clarify Boxstarter behavior on install tools

	Revision: 3b895d1
	win,msi: display license notes before installing tools

	Revision: cf284c8
	win,msi: install Boxstarter from elevated shell

	Revision: 2b7e18d
	win,msi: highlight installation of 3rd-party tools

	Revision: ebf36cd
	win,msi: install tools for native modules

PR-URL: #24344
Refs: #22645
Refs: #23987
Refs: nodejs/Release#369
Refs: #23838
Refs: nodejs/security-wg#439
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @refack @MylesBorins
    refack authored and MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    9e293c1 View commit details
    Browse the repository at this point in the history

  4. 2018-11-29, Version 10.14.1 'Dubnium' (LTS) 

    Notable Changes:

* **win/msi**: Revert changes to installer causing issues on Windows systems.

PR-URL: #24711
    @MylesBorins
    MylesBorins committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    d3dbe3a View commit details
    Browse the repository at this point in the history