esm: fix esm load bug #25491

ZYSzys · 2019-01-14T11:23:06Z

~~If module.reflect is undefined, just run into else condition.~~

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

guybedford · 2019-01-14T13:04:23Z

Unfortunately we can't just override the module map - it has to be treated as an immutable map otherwise we can possibly get race conditions in loading / different instances.

The fix here has to be to ensure the onReady function is available as soon as the moduleMap entry is set.

guybedford · 2019-01-14T13:04:34Z

(or change the architecture to not need an onReady)

ZYSzys · 2019-01-14T15:24:45Z

So how should this to be fixed specifically ？Can you please give me some more guides ?

I've changed it like we previously did: https://github.com/nodejs/node/pull/24560/files#diff-76195ce57689942222a27f0dbda6d3b7L641

Sincerely /cc @devsnek who actual implement the refactor in #24560 (comment)

devsnek · 2019-01-14T15:34:31Z

lite ci run to see if this fix passes https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2243/

guybedford · 2019-01-14T19:24:29Z

One thing to try might be checking if reflect is available once module.modulePromise has resolved. It would be good to get a test case that captures what is happening in #25482 as well.

Thanks @ZYSzys for your efforts here.

devsnek · 2019-01-14T21:23:26Z

the current change passes all tests, so maybe we're on to something?

cc @bmeck for some hopeful insight

lib/internal/modules/cjs/loader.js

guybedford · 2019-05-12T21:10:22Z

So the problem here is that the CJS cache injects into the ESM loader so they share the same instances, but in the case where the ESM loader has already loaded the module, the CJS version should not override the existing ESM version.

So the fix is correct.

I've merged the test case from #27443 into this PR, and can confirm it is fully resolved.

Please lets land this soon and backport the patch as well.

Trott

LGTM, but I'd prefer we cherry-pick or am in the test to preserve authorship for the contributor who wrote it, unless there's a good reason not to do that.

This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: #25482

ZYSzys · 2019-05-13T10:04:25Z

@Trott I've cherry-pick the test and will squash the last fixup when landed, is it ok now ?

nodejs-github-bot · 2019-05-13T10:50:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23083/

guybedford · 2019-05-13T18:02:06Z

Thanks @ZYSzys for updating that - of course we should retain the original commit.

Fixes: #25482 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: #25482 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

ZYSzys · 2019-05-14T08:21:20Z

Landed in 523a9fb...ac3b98c

@aduh95 Thanks and congratulate for your ~~first(Oh, it's not your first time 😅, but still congratulate)~~ contribution to Node.js core 🎉.

Fixes: #25482 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: #25482 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Fixes: #25482 Backport-PR-URL: #27874 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: #25482 Backport-PR-URL: #27874 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Fixes: nodejs/node#25482 PR-URL: nodejs/node#25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: nodejs/node#25482 PR-URL: nodejs/node#25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

ZYSzys force-pushed the fix-esm-bug branch from 3784449 to aa05d89 Compare January 14, 2019 14:44

guybedford reviewed Jan 15, 2019

View reviewed changes

lib/internal/modules/cjs/loader.js Show resolved Hide resolved

targos added the esm Issues and PRs related to the ECMAScript Modules implementation. label Apr 25, 2019

guybedford mentioned this pull request May 12, 2019

module: add test for cjs loader with esm flag #27443

Closed

3 tasks

guybedford approved these changes May 12, 2019

View reviewed changes

guybedford added python PRs and issues that require attention from people who are familiar with Python. and removed python PRs and issues that require attention from people who are familiar with Python. labels May 12, 2019

guybedford force-pushed the fix-esm-bug branch from 16966ec to 5a24194 Compare May 12, 2019 21:14

devsnek added the experimental Issues and PRs related to experimental features. label May 12, 2019

jasnell approved these changes May 12, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

Trott approved these changes May 13, 2019

View reviewed changes

ZYSzys and others added 3 commits May 13, 2019 17:37

esm: fix esm load bug

85891a0

test: clearing require cache crashes esm loader

243600a

This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: #25482

fixup! esm: fix esm load bug

72bdf65

ZYSzys force-pushed the fix-esm-bug branch from 1ece1c0 to 72bdf65 Compare May 13, 2019 09:54

This comment has been minimized.

Sign in to view

Trott approved these changes May 13, 2019

View reviewed changes

ZYSzys added a commit that referenced this pull request May 14, 2019

esm: fix esm load bug

6fe3692

Fixes: #25482 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

ZYSzys closed this May 14, 2019

ZYSzys deleted the fix-esm-bug branch May 14, 2019 08:57

targos pushed a commit that referenced this pull request May 14, 2019

esm: fix esm load bug

89fda94

Fixes: #25482 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

fasttime mentioned this pull request May 14, 2019

Error requiring jsdom with node --external-modules flag jsdom/jsdom#2579

Closed

BridgeAR mentioned this pull request May 21, 2019

v12.3.0 proposal #27799

Merged

4 tasks

guybedford mentioned this pull request May 24, 2019

ESM: working on 10.15.2, fails on 10.15.3? #27846

Closed

aduh95 mentioned this pull request May 25, 2019

[v10.x backport] esm: fix esm load bug #27874

Closed

3 tasks

BethGriggs pushed a commit that referenced this pull request Jun 6, 2019

esm: fix esm load bug

819a647

Fixes: #25482 Backport-PR-URL: #27874 PR-URL: #25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs mentioned this pull request Jul 17, 2019

v10.16.1 proposal #28731

Merged

slpixe mentioned this pull request Aug 5, 2019

The "request" library is not installed automatically anymore. request/request-promise#291

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

esm: fix esm load bug #25491

esm: fix esm load bug #25491

ZYSzys commented Jan 14, 2019 •

edited

Loading

guybedford commented Jan 14, 2019

guybedford commented Jan 14, 2019

ZYSzys commented Jan 14, 2019

devsnek commented Jan 14, 2019

guybedford commented Jan 14, 2019

devsnek commented Jan 14, 2019

guybedford commented May 12, 2019

This comment has been minimized.

Trott left a comment

ZYSzys commented May 13, 2019

This comment has been minimized.

nodejs-github-bot commented May 13, 2019

guybedford commented May 13, 2019

ZYSzys commented May 14, 2019 •

edited

Loading

esm: fix esm load bug #25491

esm: fix esm load bug #25491

Conversation

ZYSzys commented Jan 14, 2019 • edited Loading

Checklist

guybedford commented Jan 14, 2019

guybedford commented Jan 14, 2019

ZYSzys commented Jan 14, 2019

devsnek commented Jan 14, 2019

guybedford commented Jan 14, 2019

devsnek commented Jan 14, 2019

guybedford commented May 12, 2019

This comment has been minimized.

Trott left a comment

Choose a reason for hiding this comment

ZYSzys commented May 13, 2019

This comment has been minimized.

nodejs-github-bot commented May 13, 2019

guybedford commented May 13, 2019

ZYSzys commented May 14, 2019 • edited Loading

ZYSzys commented Jan 14, 2019 •

edited

Loading

ZYSzys commented May 14, 2019 •

edited

Loading