-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: bump minimal supported Windows version #25643
Conversation
Question: Should we also bump the check in My guess is no, because we have no reason to believe that Node will definitely break on the newly unsupported platforms, but maybe I’m wrong about that? |
It's a good question. As I see it this PR is just a formal statement, we could relegate Windows 7 support to "experimental" as per: Lines 66 to 68 in 715df64
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a doc change.
@joaocgreis would be good to make sure you are comfortable with this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are currently investigating the issue, please give us some time. Marking as -1 so nobody lands this by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am against this change at this moment, for the reasons detailed in nodejs/build#1663 (comment).
We should do this only when Windows 7/2008R2 actually reaches the EoL. Until then, this would be an invitation to remove CI or ignore results, and Windows 7/2008R2 still has many users. I don't see a reason to do this sooner.
Opened #25838 to make it clear that we can remove Windows 7/2008R2 when it becomes EoL. |
Stalled until 1.1.2020 |
Microsoft has announced that on January 14, 2020 it will end it's support for Windows 7 and Windows Server 2008 R2.
This semver-major PR bumps the stated minimal supported versions to Windows8.1/Server2012R2 so that we will be explicit with our support plan, and not state that we support and EOL platform for the next LTS node version.
As per:
node/BUILDING.md
Line 72 in 715df64
/CC @nodejs/platform-windows @nodejs/tsc
Refs: https://support.microsoft.com/en-us/help/4487594
Refs: https://support.microsoft.com/en-us/help/13853/windows-lifecycle-fact-sheet#section-2
Refs: nodejs/build#1663
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes