Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: bump minimal supported Windows version #25643

Closed
wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Jan 22, 2019

Microsoft has announced that on January 14, 2020 it will end it's support for Windows 7 and Windows Server 2008 R2.

This semver-major PR bumps the stated minimal supported versions to Windows8.1/Server2012R2 so that we will be explicit with our support plan, and not state that we support and EOL platform for the next LTS node version.

As per:

The community does not build or test against end-of-life distributions (EoL).

/CC @nodejs/platform-windows @nodejs/tsc

Refs: https://support.microsoft.com/en-us/help/4487594
Refs: https://support.microsoft.com/en-us/help/13853/windows-lifecycle-fact-sheet#section-2
Refs: nodejs/build#1663

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@refack refack added windows Issues and PRs related to the Windows platform. semver-major PRs that contain breaking changes and should be released in the next major version. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Jan 22, 2019
@refack refack added this to the 12.0.0 milestone Jan 22, 2019
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 22, 2019
@addaleax
Copy link
Member

Question: Should we also bump the check in node_main.cc?

My guess is no, because we have no reason to believe that Node will definitely break on the newly unsupported platforms, but maybe I’m wrong about that?

@refack
Copy link
Contributor Author

refack commented Jan 22, 2019

Question: Should we also bump the check in node_main.cc?

It's a good question. As I see it this PR is just a formal statement, we could relegate Windows 7 support to "experimental" as per:

node/BUILDING.md

Lines 66 to 68 in 715df64

* **Experimental**: May not compile or test suite may not pass.
These are often approaching Tier 2 support but are not quite ready.
There is at least one individual providing maintenance.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a doc change.

@mhdawson
Copy link
Member

@joaocgreis would be good to make sure you are comfortable with this as well.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refack refack requested a review from joaocgreis January 24, 2019 16:38
Copy link
Contributor

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently investigating the issue, please give us some time. Marking as -1 so nobody lands this by accident.

Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against this change at this moment, for the reasons detailed in nodejs/build#1663 (comment).

We should do this only when Windows 7/2008R2 actually reaches the EoL. Until then, this would be an invitation to remove CI or ignore results, and Windows 7/2008R2 still has many users. I don't see a reason to do this sooner.

@joaocgreis
Copy link
Member

Opened #25838 to make it clear that we can remove Windows 7/2008R2 when it becomes EoL.

@BridgeAR
Copy link
Member

BridgeAR commented Apr 3, 2019

@refack since #25838 landed and there are two -1 here, do you mind to close the PR?

@refack refack added the stalled Issues and PRs that are stalled. label Apr 3, 2019
@refack
Copy link
Contributor Author

refack commented Apr 3, 2019

Stalled until 1.1.2020

@refack refack closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. semver-major PRs that contain breaking changes and should be released in the next major version. stalled Issues and PRs that are stalled. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.