-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: clarify EoL platform support #25838
meta: clarify EoL platform support #25838
Conversation
BUILDING.md
Outdated
For production applications, run Node.js on supported platforms only. | ||
|
||
Note that end-of-life (EoL) platforms are not supported even if listed below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove "Note that".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit, but is there a reason to remove the old wording? Why not keep both? Those are complementary, as it looks to me.
Thanks for the reviews! @ChALkeR added back the old wording. |
BUILDING.md
Outdated
Note that end-of-life (EoL) platforms are not supported even if listed below | ||
and can be removed at any moment. | ||
End-of-life (EoL) platforms are not supported even if listed below and can be | ||
removed at any moment. The community does not build or test against EoL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be slightly concerned that this could be read as that we "can't" even if it's what we think need to be the case for some period of time. How about "The community avoids building or testing against EoL platforms"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed at any moment. The community does not build or test against EoL | |
removed at any time. The community does not build or test against EoL |
BUILDING.md
Outdated
For production applications, run Node.js on supported platforms only. | ||
|
||
End-of-life (EoL) platforms are not supported even if listed below and can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End-of-life (EoL) platforms are not supported even if listed below and can be | |
End-of-life (EoL) platforms are not supported, even if listed below, and can be |
I'd recommend removing the part about them being removed at any time. The important part is that they are unsupported. Removal from the table isn't really the issue, I hope? End-of-life (EoL) platforms are not supported, even if listed below.
The community does not build or test against EoL platforms. One problem left: We don't define end-of-life and there's no way for the reader to know from just this document which entries in the table this applies to. So maybe this?: Node.js does not support a platform version if a vendor has expired support for
it. In other words, Node.js does not support running on End-of-life (EoL)
platforms. This is true regardless of entries in the table below. With that wording, the reader knows we mean "EoL'ed by the vendor" as opposed to them perhaps wondering what platforms Node.js has EoL'ed. |
@Trott thanks for your review! I've updated to your suggestion. @mhdawson we can always make exceptions. Your suggestion sounds a bit contradictory to me, I'd prefer a clear message here about not supporting. I think "building and testing" is implied in "support", so I just removed that part. Let me know if you'd rather have it or have some other suggestion. (cc @ChALkeR) |
Landed in 8d2df41. |
PR-URL: #25838 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #25838 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Use stronger wording about EoL platforms. Make it clear they can be removed at any time, as should happen with Windows 7/2008R2 next year when it becomes EoL.
cc @nodejs/build
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes