Windows: small fixes and fewer warnings #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch disables two (categories of) warnings: * deprecation of GetVersionExA * possible loss of data in implicit conversion of scalar types These warnings don't seem to point out serious problems, and avoiding them in openssl is somebody else's business. PR-URL: nodejs#261 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
For consistency with the rest of the source code, use the wide-char version of this API. PR-URL: nodejs#261 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
There is no other way to retrieve the Windows version. The stated reason this API is deprecated is that applications are not supposed to check whether the Windows it's running on is recent enough. But that's not what we use it for. PR-URL: nodejs#261 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
The NODE_NET_SOCKET_READ and NODE_NET_SOCKET_WRITE macros are just no-ops on Windows, but they used to be defined as taking four parameters while being called with five arguments. Turn them into variadic macros to squelch a compiler warning. PR-URL: nodejs#261 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
The PLATFORM preprocessor symbol is defined in node.gyp, and on Windows
it's set to "win". This conflicts with a built-in preprocessor symbol
with a different value ("win32"), which makes the linker(!) complain.
Resolve this by renaming these symbols to NODE_ARCH and NODE_PLATFORM.
PR-URL: nodejs#261
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus
force-pushed
the
no-warnings
branch
from
89e6067
to
e1fe270
Compare
|
I didn't actually LGTM it, Bertje. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.