Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: small fixes and fewer warnings #261

Merged
merged 5 commits into from
Jan 8, 2015
Merged

Windows: small fixes and fewer warnings #261

merged 5 commits into from
Jan 8, 2015

Commits on Jan 8, 2015

  1. win,openssl: disable some warnings 

    This patch disables two (categories of) warnings:

  * deprecation of GetVersionExA
  * possible loss of data in implicit conversion of scalar types

These warnings don't seem to point out serious problems, and avoiding
them in openssl is somebody else's business.

PR-URL: nodejs#261
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @piscisaureus
    piscisaureus committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    e705627 View commit details
    Browse the repository at this point in the history

  2. win: use GetVersionExW instead of GetVersionExA 

    For consistency with the rest of the source code, use the wide-char
version of this API.

PR-URL: nodejs#261
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @piscisaureus
    piscisaureus committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    0ce7b91 View commit details
    Browse the repository at this point in the history

  3. win: suppress GetVersionEx deprecation warning 

    There is no other way to retrieve the Windows version. The stated reason
this API is deprecated is that applications are not supposed to check
whether the Windows it's running on is recent enough. But that's not
what we use it for.

PR-URL: nodejs#261
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @piscisaureus
    piscisaureus committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    09fe6fe View commit details
    Browse the repository at this point in the history

  4. win: fix NODE_NET_SOCKET_READ/WRITE signature 

    The NODE_NET_SOCKET_READ and NODE_NET_SOCKET_WRITE macros are just
no-ops on Windows, but they used to be defined as taking four parameters
while being called with five arguments. Turn them into variadic macros
to squelch a compiler warning.

PR-URL: nodejs#261
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @piscisaureus
    piscisaureus committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    858b558 View commit details
    Browse the repository at this point in the history

  5. src: prefix ARCH and PLATFORM with NODE_ 

    The PLATFORM preprocessor symbol is defined in node.gyp, and on Windows
it's set to "win". This conflicts with a built-in preprocessor symbol
with a different value ("win32"), which makes the linker(!) complain.
Resolve this by renaming these symbols to NODE_ARCH and NODE_PLATFORM.

PR-URL: nodejs#261
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @piscisaureus
    piscisaureus committed Jan 8, 2015
    Configuration menu
    Copy the full SHA
    e1fe270 View commit details
    Browse the repository at this point in the history