Remove --build-v8-with-gn configure option #27576

hashseed · 2019-05-06T06:04:45Z

This option is now outdated and not used any longer.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

This option is now outdated and not used any longer.

nodejs-github-bot · 2019-05-06T06:04:47Z

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3441

nodejs-github-bot · 2019-05-06T10:23:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22981/

refack · 2019-05-06T11:25:01Z

Refs: Conflicts with #26725

/CC @nodejs/build-files

refack · 2019-05-06T11:26:41Z

configure.py

-    v8_path = os.path.join('deps', 'v8')
-    print('Fetching dependencies to build V8 with GN')
-    options.build_v8_with_gn = FetchDeps(v8_path)
-  o['variables']['build_v8_with_gn'] = b(options.build_v8_with_gn)


We might consider setting this to

o['variables']['build_v8_with_gn'] = 'false'

as a make shift deprecation, since this value is exposed in process.config

refack

Please address comment. Also I'd like this to land with at least one approval from @nodejs/build-files

refack · 2019-05-13T23:59:45Z

configure.py

@@ -550,12 +546,6 @@
    help='do not use V8 includes from the bundled deps folder. ' +
         '(This mode is not officially supported for regular applications)')

-parser.add_option('--build-v8-with-gn',


Please instead of delete move to ~

node/configure.py

Lines 470 to 491 in 5cb8b25

# Dummy option for backwards compatibility

parser.add_option('--with-snapshot',

action='store_true',

dest='unused_with_snapshot',

help=optparse.SUPPRESS_HELP)

parser.add_option('--without-snapshot',

action='store_true',

dest='without_snapshot',

help=optparse.SUPPRESS_HELP)

parser.add_option('--without-siphash',

action='store_true',

dest='without_siphash',

help=optparse.SUPPRESS_HELP)

parser.add_option('--code-cache-path',

action='store',

dest='code_cache_path',

help='optparse.SUPPRESS_HELP')

# End dummy list.

with help=optparse.SUPPRESS_HELP

^^^
To avoid making this semver-major.

Trott · 2020-04-22T02:29:48Z

@hashseed Presumably this is something you'd still like to land, right?

Everyone else: Are we OK landing this semver-major, or do we want to follow @refack's suggestion instead?

@refack Are you still -1 on landing this semver-major?

jasnell · 2020-06-25T22:50:01Z

@nodejs/build ... we need a decision on whether this needs to move forward.

@nodejs/tsc .... Given that @refack has not been active lately, should we allow this to move forward over their objection?

rvagg · 2020-06-26T10:24:58Z

+1 for merging as is from me as a @nodejs/build representative if that helps. I don't see a strong need to semver-major it either. Do we imagine people are relying on process.config.variables in a way that would break if a property was removed? TSC's call I suppose.

richardlau · 2020-06-26T10:46:02Z

I don't see a strong need to semver-major it either. Do we imagine people are relying on process.config.variables in a way that would break if a property was removed?

We usually err on the side of caution when removing configure flags and have generally tended to prefer making them no-ops rather than outright deletion (as requested by @refack). I'd be very reluctant, for example, to land this on an LTS line.

And yes unfortunately it turns out that things we leak in terms of config do end up affecting addons in all sorts of unexpected ways (e.g. nodejs/node-gyp#1457).

~

nodejs-github-bot · 2020-09-22T02:24:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33185/

gengjiawen · 2020-09-22T03:18:24Z

@hashseed Can you rebase this PR and amend the commit message with subsystem prefix like build: remove --build-v8-with-gn configure option ?

mmarchini · 2020-09-22T03:40:56Z

I think in this case it's reasonable for the collaborator landing to fix the commit before landing (of course you can't use commit queue in that case :/ )

gengjiawen · 2020-09-23T10:54:40Z

I think in this case it's reasonable for the collaborator landing to fix the commit before landing (of course you can't use commit queue in that case :/ )

I am just a little worried since it's not synced with upstream too long. I will give it a try :)

This option is now outdated and not used any longer. PR-URL: #27576 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

gengjiawen · 2020-09-23T10:58:22Z

Landed in a117887

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

This option is now outdated and not used any longer. PR-URL: nodejs#27576 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

Remove --build-v8-with-gn configure option

5cb8b25

This option is now outdated and not used any longer.

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label May 6, 2019

targos approved these changes May 6, 2019

View reviewed changes

Trott approved these changes May 6, 2019

View reviewed changes

BridgeAR approved these changes May 6, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2019

refack reviewed May 6, 2019

View reviewed changes

cjihrig approved these changes May 6, 2019

View reviewed changes

tniessen approved these changes May 6, 2019

View reviewed changes

BridgeAR approved these changes May 13, 2019

View reviewed changes

refack previously requested changes May 13, 2019

View reviewed changes

refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2019

refack reviewed May 13, 2019

View reviewed changes

refack added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 13, 2019

Trott force-pushed the master branch from 1ecc406 to 49cf67e Compare September 17, 2019 16:51

devnexen force-pushed the master branch from e8a4568 to 5289f80 Compare December 26, 2019 19:46

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19

jasnell added the stalled Issues and PRs that are stalled. label Jun 25, 2020

gengjiawen requested a review from refack September 8, 2020 01:16

gengjiawen added request-ci Add this label to start a Jenkins CI on a PR. and removed stalled Issues and PRs that are stalled. labels Sep 22, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2020

gengjiawen approved these changes Sep 23, 2020

View reviewed changes

gengjiawen closed this Sep 23, 2020

BethGriggs mentioned this pull request Oct 14, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

vweevers mentioned this pull request Nov 18, 2020

Added fix for building node 10 prebuild/prebuildify#48

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove --build-v8-with-gn configure option #27576

Remove --build-v8-with-gn configure option #27576

hashseed commented May 6, 2019

nodejs-github-bot commented May 6, 2019

nodejs-github-bot commented May 6, 2019

refack commented May 6, 2019

refack May 6, 2019

refack left a comment

refack May 13, 2019

refack May 14, 2019

Trott commented Apr 22, 2020

jasnell commented Jun 25, 2020

rvagg commented Jun 26, 2020

richardlau commented Jun 26, 2020

nodejs-github-bot commented Sep 22, 2020

gengjiawen commented Sep 22, 2020

mmarchini commented Sep 22, 2020

gengjiawen commented Sep 23, 2020

gengjiawen commented Sep 23, 2020

	# Dummy option for backwards compatibility
	parser.add_option('--with-snapshot',
	action='store_true',
	dest='unused_with_snapshot',
	help=optparse.SUPPRESS_HELP)

	parser.add_option('--without-snapshot',
	action='store_true',
	dest='without_snapshot',
	help=optparse.SUPPRESS_HELP)

	parser.add_option('--without-siphash',
	action='store_true',
	dest='without_siphash',
	help=optparse.SUPPRESS_HELP)

	parser.add_option('--code-cache-path',
	action='store',
	dest='code_cache_path',
	help='optparse.SUPPRESS_HELP')

	# End dummy list.

Remove --build-v8-with-gn configure option #27576

Remove --build-v8-with-gn configure option #27576

Conversation

hashseed commented May 6, 2019

Checklist

nodejs-github-bot commented May 6, 2019

nodejs-github-bot commented May 6, 2019

refack commented May 6, 2019

refack May 6, 2019

Choose a reason for hiding this comment

refack left a comment

Choose a reason for hiding this comment

refack May 13, 2019

Choose a reason for hiding this comment

refack May 14, 2019

Choose a reason for hiding this comment

Trott commented Apr 22, 2020

jasnell commented Jun 25, 2020

rvagg commented Jun 26, 2020

richardlau commented Jun 26, 2020

nodejs-github-bot commented Sep 22, 2020

gengjiawen commented Sep 22, 2020

mmarchini commented Sep 22, 2020

gengjiawen commented Sep 23, 2020

gengjiawen commented Sep 23, 2020