http2: check for valid headers #33193

rexagod · 2020-05-01T11:22:46Z

checks validity for request, writeHead, and setHeader methods

refs: #29829 (5th sub-issue)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

checks validity for request, writeHead, and setHeader methods refs: nodejs#29829

ronag · 2020-05-01T11:41:54Z

@rexagod when you ref #29829 it would be nice if you could be a bit more explicit in regards to which item in the check list you are referring to.

rexagod · 2020-05-01T11:52:51Z

@ronag Thanks for the heads up! I've added the sub-issue. Also, all of my other pull requests stemming from #29829 are formatted as i-29829-[sub-issue-number] so those sub-issues shouldn't be a problem to locate.

doc/api/errors.md

lib/internal/http2/core.js

addaleax

LGTM as semver-major

@nodejs/tsc

nodejs-github-bot · 2020-05-07T23:25:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31221/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2375/

BridgeAR · 2020-05-07T23:28:35Z

@rexagod I am not sure if the tests cover all of the added code. Would you mind adding a few more to verify it's fully covered? That would be great!

rexagod · 2020-05-10T20:06:02Z

@BridgeAR I think this should cover all the cases.

nodejs-github-bot · 2020-05-10T20:10:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31269/ 💚

addaleax · 2020-05-19T21:59:12Z

@jasnell Does this LGTY? It needs another TSC approval.

BridgeAR

LGTM. Just left a nit

lib/internal/http2/core.js

mcollina

lgtm

BridgeAR

I missed that it used a for in loop. I updated my suggested change to prevent checking the prototype. That should be addressed before landing.

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

lib/internal/http2/core.js

nodejs-github-bot · 2020-05-25T17:05:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31561/

nodejs-github-bot · 2020-05-28T15:45:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31609/

BridgeAR · 2020-05-30T01:56:51Z

Landed in df31f71

checks validity for request, writeHead, and setHeader methods PR-URL: nodejs#33193 Refs: nodejs#29829 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

http2: header field valid checks

388915a

checks validity for request, writeHead, and setHeader methods refs: nodejs#29829

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 1, 2020

jasnell reviewed May 1, 2020

View reviewed changes

doc/api/errors.md Outdated Show resolved Hide resolved

ronag added http2 Issues or PRs related to the http2 subsystem. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels May 1, 2020

fixup: remove unnecessary error

d092e96

addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 7, 2020

addaleax reviewed May 7, 2020

View reviewed changes

lib/internal/http2/core.js Show resolved Hide resolved

addaleax approved these changes May 7, 2020

View reviewed changes

test: add checks for writeHead

a0575e0

fixup: lint

502c549

ronag approved these changes May 10, 2020

View reviewed changes

BridgeAR approved these changes May 23, 2020

View reviewed changes

lib/internal/http2/core.js Outdated Show resolved Hide resolved

mcollina approved these changes May 23, 2020

View reviewed changes

BridgeAR requested changes May 23, 2020

View reviewed changes

Update lib/internal/http2/core.js

49f5092

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

ronag reviewed May 23, 2020

View reviewed changes

lib/internal/http2/core.js Outdated Show resolved Hide resolved

fixup: review suggestions

32689ba

BridgeAR approved these changes May 25, 2020

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 25, 2020

BridgeAR closed this May 30, 2020

rexagod mentioned this pull request Jun 6, 2020

The differences between http2 compatibility API and http[s] #29829

Open

32 tasks

BethGriggs mentioned this pull request Sep 1, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

bl-ue mentioned this pull request Jun 8, 2021

http2 stream.end error #36860

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http2: check for valid headers #33193

http2: check for valid headers #33193

rexagod commented May 1, 2020 •

edited

Loading

ronag commented May 1, 2020

rexagod commented May 1, 2020

addaleax left a comment

nodejs-github-bot commented May 7, 2020 •

edited by addaleax

Loading

BridgeAR commented May 7, 2020

rexagod commented May 10, 2020

nodejs-github-bot commented May 10, 2020 •

edited by BridgeAR

Loading

addaleax commented May 19, 2020

BridgeAR left a comment

mcollina left a comment

BridgeAR left a comment

nodejs-github-bot commented May 25, 2020

nodejs-github-bot commented May 28, 2020

BridgeAR commented May 30, 2020

http2: check for valid headers #33193

http2: check for valid headers #33193

Conversation

rexagod commented May 1, 2020 • edited Loading

Checklist

ronag commented May 1, 2020

rexagod commented May 1, 2020

addaleax left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented May 7, 2020 • edited by addaleax Loading

BridgeAR commented May 7, 2020

rexagod commented May 10, 2020

nodejs-github-bot commented May 10, 2020 • edited by BridgeAR Loading

addaleax commented May 19, 2020

BridgeAR left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

BridgeAR left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented May 25, 2020

nodejs-github-bot commented May 28, 2020

BridgeAR commented May 30, 2020

rexagod commented May 1, 2020 •

edited

Loading

nodejs-github-bot commented May 7, 2020 •

edited by addaleax

Loading

nodejs-github-bot commented May 10, 2020 •

edited by BridgeAR

Loading