Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] esm: fix esm load bug #27874

Closed
wants to merge 3 commits into from
Closed

[v10.x backport] esm: fix esm load bug #27874

wants to merge 3 commits into from

Commits on May 25, 2019

  1. esm: fix esm load bug 

    Fixes: nodejs#25482

PR-URL: nodejs#25491
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @ZYSzys @aduh95
    ZYSzys authored and aduh95 committed May 25, 2019
    Configuration menu
    Copy the full SHA
    ef51e92 View commit details
    Browse the repository at this point in the history

  2. test: clearing require cache crashes esm loader 

    This test shows the regression introduced in v11.4.0: clearing out the
require.cache crashes node when using the `--experimental-modules` flag.
Refs: nodejs#25482

PR-URL: nodejs#25491
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @aduh95
    aduh95 committed May 25, 2019
    Configuration menu
    Copy the full SHA
    6de1849 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. Fix line change

    @aduh95
    aduh95 authored May 26, 2019
    Configuration menu
    Copy the full SHA
    77276a4 View commit details
    Browse the repository at this point in the history