Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make ELDHistogram a HandleWrap #29317

Closed
wants to merge 2 commits into from
Closed

src: make ELDHistogram a HandleWrap #29317

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with HandleWraps.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: make ELDHistogram a HandleWrap
00dc5e9 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 25, 2019
@addaleax addaleax added perf_hooks Issues and PRs related to the implementation of the Performance Timing API. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 25, 2019
jasnell
jasnell approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Something to keep in mind is I'm planning to abstract out the base histogram object wrapper implementation so it can be reused in more contexts (such as QUIC)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25269/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25286/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 7, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25387/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25388/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25389/

@Trott
Copy link
Member

Trott commented Sep 8, 2019

Landed in 0af62aa

Trott pushed a commit that referenced this pull request Sep 8, 2019
@addaleax @Trott
src: make ELDHistogram a HandleWrap
0af62aa 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: #29317
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott closed this Sep 8, 2019
@addaleax addaleax deleted the eldh-handlewrap branch September 9, 2019 22:02
targos pushed a commit that referenced this pull request Sep 20, 2019
@addaleax @targos
src: make ELDHistogram a HandleWrap
909f4b6 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: #29317
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Sep 21, 2019
@addaleax
src: fix closing weak HandleWraps on GC
20aae9d 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs#29317
@addaleax addaleax mentioned this pull request Sep 21, 2019
Closed
3 tasks
bcoe pushed a commit that referenced this pull request Sep 21, 2019
@addaleax @bcoe
src: fix closing weak HandleWraps on GC
e74f308 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Sep 23, 2019
@addaleax @targos
src: fix closing weak HandleWraps on GC
fb88273 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@addaleax @BridgeAR
src: make ELDHistogram a HandleWrap
67aa5ef 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: #29317
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@addaleax @BridgeAR
src: fix closing weak HandleWraps on GC
f84f1db 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
This was referenced Sep 26, 2019
Closed
Closed
Closed
Closed
addaleax added a commit to nodejs/quic that referenced this pull request Sep 29, 2019
@addaleax
src: make ELDHistogram a HandleWrap
f787f88 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to nodejs/quic that referenced this pull request Sep 29, 2019
@addaleax
src: fix closing weak HandleWraps on GC
1af3703 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit to nodejs/quic that referenced this pull request Oct 1, 2019
@addaleax @jasnell
src: make ELDHistogram a HandleWrap
4383759 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to nodejs/quic that referenced this pull request Oct 1, 2019
@addaleax @jasnell
src: fix closing weak HandleWraps on GC
6af9e9b 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax added a commit to nodejs/quic that referenced this pull request Oct 2, 2019
@addaleax
src: make ELDHistogram a HandleWrap
b7b71c0 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to nodejs/quic that referenced this pull request Oct 2, 2019
@addaleax
src: fix closing weak HandleWraps on GC
6cf3def 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit to nodejs/quic that referenced this pull request Oct 2, 2019
@addaleax @jasnell
src: make ELDHistogram a HandleWrap
3b89448 
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with `HandleWrap`s.

PR-URL: nodejs/node#29317
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to nodejs/quic that referenced this pull request Oct 2, 2019
@addaleax @jasnell
src: fix closing weak HandleWraps on GC
154644f 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Qard Qard mentioned this pull request Dec 22, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @Trott @jasnell