Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix closing weak HandleWraps on GC #29640

Closed
wants to merge 2 commits into from
Closed

src: fix closing weak HandleWraps on GC #29640

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Thanks to @bcoe for pointing me to this as the cause of the failure in https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/28455/console.

Refs: #29317

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
src: fix closing weak HandleWraps on GC
20aae9d 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs#29317
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 21, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25615/

@addaleax
Copy link
Member Author

This currently breaks CI for the unrelated #28960, so feel free to 👍 this comment to approve fast-tracking.

@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 21, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25617/

Trott
Trott approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question but nothing that should block this from landing and fixing CI. My comment can be addressed in another PR or not at all.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25618/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25620/

bcoe pushed a commit that referenced this pull request Sep 21, 2019
@addaleax @bcoe
src: fix closing weak HandleWraps on GC
e74f308 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@bcoe
Copy link
Contributor

bcoe commented Sep 21, 2019

Landed in e74f308

@bcoe bcoe closed this Sep 21, 2019
targos pushed a commit that referenced this pull request Sep 23, 2019
@addaleax @targos
src: fix closing weak HandleWraps on GC
fb88273 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@addaleax @BridgeAR
src: fix closing weak HandleWraps on GC
f84f1db 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: #29317

PR-URL: #29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
addaleax added a commit to nodejs/quic that referenced this pull request Sep 29, 2019
@addaleax
src: fix closing weak HandleWraps on GC
1af3703 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit to nodejs/quic that referenced this pull request Oct 1, 2019
@addaleax @jasnell
src: fix closing weak HandleWraps on GC
6af9e9b 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax added a commit to nodejs/quic that referenced this pull request Oct 2, 2019
@addaleax
src: fix closing weak HandleWraps on GC
6cf3def 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit to nodejs/quic that referenced this pull request Oct 2, 2019
@addaleax @jasnell
src: fix closing weak HandleWraps on GC
154644f 
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.

Refs: nodejs/node#29317

PR-URL: nodejs/node#29640
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @bcoe @Trott